Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using internal uuid implementation instead of uuid library to support es modules #878

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Switch to using internal uuid implementation instead of uuid library to support es modules #878

merged 1 commit into from
Aug 2, 2019

Conversation

jasonnutter
Copy link
Contributor

@jasonnutter jasonnutter commented Jul 29, 2019 •
edited
Loading

uuid library is not compatible with ES modules, and we already have our own implementation of uuid, so switch to using that instead.

Fixes #874

@jasonnutter jasonnutter added the compatibility Related to compatibility with specific frameworks, environments, browsers, etc. label Jul 29, 2019
@jasonnutter jasonnutter added this to the 1.2.0 milestone Jul 29, 2019
@DarylThayil
Copy link
Contributor

Lgtm

sameerag
sameerag approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@DarylThayil
Copy link
Contributor

merging

@DarylThayil DarylThayil merged commit 4e8ba14 into dev Aug 2, 2019
@jasonnutter jasonnutter deleted the uuid-es-modules branch August 20, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameerag sameerag sameerag approved these changes

@DarylThayil DarylThayil DarylThayil approved these changes

Assignees

@jasonnutter jasonnutter

Labels
compatibility Related to compatibility with specific frameworks, environments, browsers, etc.
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.

The uuid dependency is not an es6 module and does not work in the browser
3 participants
@jasonnutter @DarylThayil @sameerag