Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-working samples and add a redirect sample #959

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Remove non-working samples and add a redirect sample #959

merged 3 commits into from
Sep 13, 2019

Conversation

sameerag
Copy link
Member

Updating the samples:

  • removing unused samples under VanillaJSTestApp folder
  • adding index_redirect.html for redirect usecases

@sameerag sameerag mentioned this pull request Aug 29, 2019
Closed
5 tasks
DarylThayil
DarylThayil reviewed Sep 3, 2019
View reviewed changes
lib/msal-core/samples/VanillaJSTestApp/index.html
auth: {
clientId: "Enter_your_client_id",
// clientId: "245e9392-c666-4d51-8f8a-bfd9e55b2456",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to leave this in here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, its helpful to have a demo client id available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an internal only client id?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like is there concern around exposing to others

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, its been in the repo for a while, hasn't it? And its only setup for localhost.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I created this application (in the portal) just for demo purposes, so no issues in making this public. I left it alone here in the sample to have it ready for anyone to test it.

@jasonnutter jasonnutter merged commit 4d46b8b into dev Sep 13, 2019
@sameerag sameerag deleted the remove_unused_samples branch October 3, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarylThayil DarylThayil DarylThayil approved these changes

@jasonnutter jasonnutter jasonnutter approved these changes

@pkanher617 pkanher617 Awaiting requested review from pkanher617

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sameerag @jasonnutter @DarylThayil