-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force refresh support for acquire_token_silent broker flow #737
base: dev
Are you sure you want to change the base?
Conversation
@rayluo - do you have any more comments on this PR? This is blocking a PIM scenario (see https://identitydivision.visualstudio.com/Engineering/_boards/board/t/Auth%20Client%20-%20CPP/Backlog%20items/?workitem=2806005) |
@Ugonnaak1 , the PR itself looks good. I refactored just a little bit. One more thing needs to be done.
You only tested it on Windows at that time. But the |
c10ace1
to
1f923c2
Compare
1f923c2
to
c10ace1
Compare
@rayluo I've retested on Windows and the test are passing. However, I'm unable to test on Mac. Would you be able to confirm it passes on Mac? Thanks |
@fengga in your team worked on MSAL Python in the Mac broker project recently. Would you please work with @fengga to complete the Mac test and leave a comment in the PR attesting that the Mac test has been performed? After that, please ping me again for a final signoff. |
@rayluo It appears the logic of comparing the at_to_renew with broker returned AT is not implemented on Mac and a feature request needs to be put in to have this implemented. Since this feature was initially requested just for windows, could we merge it so the card this is tracking in ADO may be closed? Thanks! |
Hmm, if I remember correctly, you once mentioned (in here?) that the test on Mac did not pass. Was that message deleted? Regardless, what is the investigation outcome? How difficult to solve that? Or at least, do we know which component causes the issue? MSAL Python is a cross-platform library so all its behaviors shall have cross-platform parity. Each merge shall not introduce disparity. If your concern is that ADO card, you can close the old card and create a new card for "at_to_renew on mac platform". |
AB#2806005
Changes proposed in this request
Currently Broker flows don't allow bypassing broker cache, however force_refresh enables bypassing of msals token cache. My change involves adding the implementation that will call into pymsalruntime to renew the access token given force_refresh is set to true
Testing
Testing done using manual validation