Skip to content

Commit

Permalink
Jmprieur/separate graph (#534)
Browse files Browse the repository at this point in the history
* Fix for #506
_ Separate Microsoft Graph support from Microsoft.Identity.web
_  Udapting the templates
_ Addressing PR comments
  • Loading branch information
jmprieur authored Sep 2, 2020
1 parent bdab00f commit fde3687
Show file tree
Hide file tree
Showing 23 changed files with 205 additions and 77 deletions.
12 changes: 12 additions & 0 deletions Microsoft.Identity.Web.sln
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "IntegrationTests", "Integra
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "IntegrationTestService", "tests\IntegrationTests\IntegrationTestService\IntegrationTestService.csproj", "{D3C5B5F5-617E-4206-B9EF-915A27AF6863}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Identity.Web.MicrosoftGraph", "src\Microsoft.Identity.Web.MicrosoftGraph\Microsoft.Identity.Web.MicrosoftGraph.csproj", "{9A736AA6-54DD-47E0-85D9-3CFEE2CDD92A}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Identity.Web.MicrosoftGraphBeta", "src\Microsoft.Identity.Web.MicrosoftGraphBeta\Microsoft.Identity.Web.MicrosoftGraphBeta.csproj", "{B68226EF-2A43-4040-A583-061F25A4DE21}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -171,6 +175,14 @@ Global
{69ECC686-3077-4E46-97F6-D287A4821FD4}.Debug|Any CPU.Build.0 = Debug|Any CPU
{69ECC686-3077-4E46-97F6-D287A4821FD4}.Release|Any CPU.ActiveCfg = Release|Any CPU
{69ECC686-3077-4E46-97F6-D287A4821FD4}.Release|Any CPU.Build.0 = Release|Any CPU
{9A736AA6-54DD-47E0-85D9-3CFEE2CDD92A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9A736AA6-54DD-47E0-85D9-3CFEE2CDD92A}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9A736AA6-54DD-47E0-85D9-3CFEE2CDD92A}.Release|Any CPU.ActiveCfg = Release|Any CPU
{9A736AA6-54DD-47E0-85D9-3CFEE2CDD92A}.Release|Any CPU.Build.0 = Release|Any CPU
{B68226EF-2A43-4040-A583-061F25A4DE21}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{B68226EF-2A43-4040-A583-061F25A4DE21}.Debug|Any CPU.Build.0 = Debug|Any CPU
{B68226EF-2A43-4040-A583-061F25A4DE21}.Release|Any CPU.ActiveCfg = Release|Any CPU
{B68226EF-2A43-4040-A583-061F25A4DE21}.Release|Any CPU.Build.0 = Release|Any CPU
{D3C5B5F5-617E-4206-B9EF-915A27AF6863}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{D3C5B5F5-617E-4206-B9EF-915A27AF6863}.Debug|Any CPU.Build.0 = Debug|Any CPU
{D3C5B5F5-617E-4206-B9EF-915A27AF6863}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.3.0-preview</ClientSemVer>
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.4.0-preview</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<PackageVersion>$(ClientSemVer)</PackageVersion>

Expand Down
7 changes: 7 additions & 0 deletions ProjectTemplates/nuget.config
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@
-->
<packageSources>
<add key="NuGet official package source" value="https://api.nuget.org/v3/index.json" />

<!-- Test with the latest version of MIcrosoft.Identity.Web available from the repo [built with dotnet pack] -->
<!--<add key="Microsoft.Identity.Web from build" value="../src/Microsoft.Identity.Web/bin/Debug" />
<add key="Microsoft.Identity.Web.UI from build" value="../src/Microsoft.Identity.Web.UI/bin/Debug" />
<add key="Microsoft.Identity.Web.MicrosoftGraph from build" value="../src/Microsoft.Identity.Web.MicrosoftGraph/bin/Debug" />-->


<!--
<add key="Preview-dotnetcore-sdk" value="C:\dotnetcore\Windows_Packages\Windows_Packages\Release\Shipping" />
<add key="dotnet5" value="https://dnceng.pkgs.visualstudio.com/public/_packaging/dotnet5/nuget/v3/index.json" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Identity.Web" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.4.*-*" />
<!--#if (GenerateGraph) -->
<PackageReference Include="Microsoft.Identity.Web.MicrosoftGraph" Version="0.4.*-*" />
<!--#endif -->
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Server" Version="3.2.0" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.*-*" />
<!--#if (GenerateGraph) -->
<PackageReference Include="Microsoft.Identity.Web.MicrosoftGraph" Version="0.4.*-*" />
<!--#endif -->
</ItemGroup>

<PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Identity.Web" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.4.*-*" />
<!--#if (GenerateGraph) -->
<PackageReference Include="Microsoft.Identity.Web.MicrosoftGraph" Version="0.4.*-*" />
<!--#endif -->
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Identity.Web" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.*-*" />
<PackageReference Include="Microsoft.Identity.Web.UI" Version="0.4.*-*" />
<!--#if (GenerateGraph) -->
<PackageReference Include="Microsoft.Identity.Web.MicrosoftGraph" Version="0.4.*-*" />
<!--#endif -->
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Identity.Web" Version="0.3.*-*" />
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.*-*" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="5.5.1" />
<!--#if (GenerateGraph) -->
<PackageReference Include="Microsoft.Identity.Web.MicrosoftGraph" Version="0.4.*-*" />
<!--#endif -->
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion ProjectTemplates/test-templates.bat
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ echo "Build and Install templates"
dotnet pack AspNetCoreMicrosoftIdentityWebProjectTemplates.csproj
cd bin
cd Debug
dotnet new -i Microsoft.Identity.Web.ProjectTemplates.0.3.0-preview.nupkg
dotnet new -i Microsoft.Identity.Web.ProjectTemplates.0.4.0-preview.nupkg

echo "Test templates"
mkdir tests
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>

<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.4.0-localbuild</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(ClientSemVer)</Version>

<DefineConstants>$(DefineConstants);WEB</DefineConstants>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<!-- Copyright needs to be in the form of © not (c) to be compliant -->
<Title>Microsoft Identity Web, Microsoft Graph helper</Title>
<Authors>Microsoft</Authors>
<Company>Microsoft Corporation</Company>
<Product>Microsoft Identity Web</Product>
<Description>
This package enables ASP.NET Core web apps and web APIs to use the Microsoft identity platform (formerly Azure AD v2.0).
This package is specifically used for web applications, which sign-in users and call Microsoft Graph, and for protected web APIs
that call Microsoft Graph.
</Description>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/AzureAD/microsoft-identity-web</PackageProjectUrl>
<RepositoryUrl>https://github.com/AzureAD/microsoft-identity-web</RepositoryUrl>
<PackageReleaseNotes>The release notes are available at https://github.com/AzureAD/microsoft-identity-web/releases and the roadmap at https://github.com/AzureAD/microsoft-identity-web/wiki#roadmap </PackageReleaseNotes>
<PackageTags>Microsoft Identity Web;Microsoft identity platform;Microsoft.Identity.Web;.NET;ASP.NET Core;Web App;Web API;B2C;Azure Active Directory;AAD;Identity;Authentication;Authorization</PackageTags>
</PropertyGroup>
<PropertyGroup Label="Source Link">
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<!-- Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" />
</ItemGroup>

<ItemGroup>
<None Include="..\..\LICENSE">
<Pack>True</Pack>
<PackagePath></PackagePath>
</None>
</ItemGroup>

<ItemGroup Label="Build Tools" Condition="$([MSBuild]::IsOsPlatform('Windows'))">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Graph" Version="3.12.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Microsoft.Identity.Web\Microsoft.Identity.Web.csproj" />
</ItemGroup>

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>../../build/MSAL.snk</AssemblyOriginatorKeyFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
</PropertyGroup>

<PropertyGroup>
<!-- The MSAL.snk has both private and public keys -->
<DelaySign>false</DelaySign>
</PropertyGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>

<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.4.0-localbuild</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(ClientSemVer)</Version>

<DefineConstants>$(DefineConstants);WEB</DefineConstants>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<!-- Copyright needs to be in the form of © not (c) to be compliant -->
<Title>Microsoft Identity Web, Microsoft Graph helper</Title>
<Authors>Microsoft</Authors>
<Company>Microsoft Corporation</Company>
<Product>Microsoft Identity Web</Product>
<Description>
This package enables ASP.NET Core web apps and web APIs to use the Microsoft identity platform (formerly Azure AD v2.0).
This package is specifically used for web applications, which sign-in users and call Microsoft Graph Beta, and for protected web APIs
that call Microsoft Graph Beta.
</Description>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageProjectUrl>https://github.com/AzureAD/microsoft-identity-web</PackageProjectUrl>
<RepositoryUrl>https://github.com/AzureAD/microsoft-identity-web</RepositoryUrl>
<PackageReleaseNotes>The release notes are available at https://github.com/AzureAD/microsoft-identity-web/releases and the roadmap at https://github.com/AzureAD/microsoft-identity-web/wiki#roadmap </PackageReleaseNotes>
<PackageTags>Microsoft Identity Web;Microsoft identity platform;Microsoft.Identity.Web;.NET;ASP.NET Core;Web App;Web API;B2C;Azure Active Directory;AAD;Identity;Authentication;Authorization</PackageTags>
</PropertyGroup>
<PropertyGroup Label="Source Link">
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<!-- Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="..\..\stylecop.json" />
</ItemGroup>

<ItemGroup>
<Compile Include="..\Microsoft.Identity.Web.MicrosoftGraph\MicrosoftGraphExtensions.cs" Link="MicrosoftGraphExtensions.cs" />
<Compile Include="..\Microsoft.Identity.Web.MicrosoftGraph\MicrosoftGraphOptions.cs" Link="MicrosoftGraphOptions.cs" />
<Compile Include="..\Microsoft.Identity.Web.MicrosoftGraph\TokenAcquisitionCredentialProvider.cs" Link="TokenAcquisitionCredentialProvider.cs" />
</ItemGroup>

<ItemGroup>
<None Include="..\..\LICENSE">
<Pack>True</Pack>
<PackagePath></PackagePath>
</None>
</ItemGroup>

<ItemGroup Label="Build Tools" Condition="$([MSBuild]::IsOsPlatform('Windows'))">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Graph.Beta" Version="0.25.0-preview" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Microsoft.Identity.Web\Microsoft.Identity.Web.csproj" />
</ItemGroup>

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1; net5.0</TargetFrameworks>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>../../build/MSAL.snk</AssemblyOriginatorKeyFile>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
</PropertyGroup>

<PropertyGroup>
<!-- The MSAL.snk has both private and public keys -->
<DelaySign>false</DelaySign>
</PropertyGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>

<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.2.0-localbuild</ClientSemVer>
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.4.0-localbuild</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(ClientSemVer)</Version>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Microsoft.Identity.Web
{
/// <summary>
/// Options passed-in to call downstream web APIs. To call Microsoft Graph, see rather
/// <see cref="MicrosoftGraphOptions"/>.
/// <c>MicrosoftGraphOptions"</c> in the <c>Microsoft.Identity.Web.MicrosoftGraph</c> assembly.
/// </summary>
public class DownstreamWebApiOptions
{
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.Identity.Web/Microsoft.Identity.Web.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>

<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.2.0-localbuild</ClientSemVer>
<ClientSemVer Condition="'$(ClientSemVer)' == ''">0.4.0-localbuild</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(ClientSemVer)</Version>

Expand Down Expand Up @@ -94,7 +94,6 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.Graph" Version="3.9.0" />
<PackageReference Include="Microsoft.Identity.Client" Version="4.17.1" />
<PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.164">
<PrivateAssets>all</PrivateAssets>
Expand Down
63 changes: 1 addition & 62 deletions src/Microsoft.Identity.Web/Microsoft.Identity.Web.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit fde3687

Please sign in to comment.