(Smaller) PR to add MicrosoftGraphClientService to the new API. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: - see if we could have some commonalities between the Web app and Web API builder (configuration?) - Enfoce configuration for CallsWebAPI can only be called if configuration for the AddMicrosoftWebApp/Api
Fixing a few.
- Renaming AddMicrosoftWebApp to AddMicrosoftIdentityPlatformWebApp, - Renaming AddMicrosoftWebApi to AddMicrosoftIdentityPlatformWebApi, - MicrososoftAppCallingWebApiAuthenticationBuilder.AddInXXXTokenCaches etc ... return their parent builder.
… (#424) * Make GetTokenForAppAsync less confusing and allow to pass tenantId #413 Checked with @hpsin and here is what we agreed to: - Change the signature of `GetAccessTokenForUserAsync` to take a `string` (instead of a `IEnumerable<string>`) as there is only one possible string for a given resource of App Id URI AppIdUri: "AppIdUri/.default". Check that the resource ends in "./default" - Add an additional optional parameter `tenant` to support this scenario, and verify that this tenant is not organizations (and of course common and consumers, which don't make sense) ```CSharp public async Task<string> GetAccessTokenForAppAsync(string scope, string? tenant = null) ``` * Update src/Microsoft.Identity.Web/ITokenAcquisition.cs Co-authored-by: jennyf19 <jeferrie@microsoft.com> * Addressing PR feedback: - Adding an aka.ms link to the error messages (https://aka.ms/ms-id-web/daemon-scenarios) - using constants for the meta-tenants - Testing all the meta tenant Thanks @jennyf19 for this PR feedback * Addressing @hpsin 's PR feedback.
…ntityWebApp - Updating the ITokenAcquisition.GetTokenForAppAsync signature to match the class.
jmprieur
commented
Aug 12, 2020
|
|
||
| namespace blazor |
There was a problem hiding this comment.
Copied the TokenAcquisitionCredentialProvider from the blazor sample)
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/MicrosoftGraphServiceExtensions.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/TokenAcquisitionCredentialProvider.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 12, 2020
| @@ -30,7 +30,8 @@ public void ConfigureServices(IServiceCollection services) | |||
| services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme) | |||
| .AddMicrosoftIdentityWebApp(Configuration.GetSection("AzureAd")) | |||
| .EnableTokenAcquisitionToCallDownstreamApi() | |||
| .AddInMemoryTokenCaches(); // Add a delegate overload. Should return the parent builder | |||
| .AddMicrosoftGraphServiceClient(Configuration.GetSection("GraphBeta")) | |||
There was a problem hiding this comment.
nit: question for asp .net maybe....AddMicrosoftGraph? or leave as is...i'm not sure. ...ServiceClient is more precise
|
looks good. i think there is some work to do around unit testing. i'll take see if i have time today to take a look at that. |
jennyf19
reviewed
Aug 13, 2020
src/Microsoft.Identity.Web/MicrosoftGraph/TokenAcquisitionCredentialProvider.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Aug 13, 2020
* fix PR feedback for xml comments and constants * fix spelling + add more const
…ureAD/microsoft-identity-web into jennyf/newApiPlusGraphService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Add the
MicrosoftGraphOptions,MicrosoftGraphServiceExtensions,TokenAcquisitionCredentialProvider(coming from the Blazor sample)Update the test apps that where using graph
Updating the samples requires the following:
BaseUrlandScopes)services.AddMicrosoftGraph(scopes, Configuration.GetValue<string>("CalledApi:CalledApiUrl"));and replace it by what we agreed on with Damien: