This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
Using bearer strategy passReqToCallback = true does not work #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.0.3
…being used instead of self._options.passReqToCallback. This cause the callback passed in to a new strategy to get called with the two param option even when "passReqToCallback" is set to true.
|
Hi @jes5e, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #254 - passReqToCallback does not work with bearer strategy
When 'passReqToCallback' is set to true, the callback passed in to a new strategy should get called with the three param option (req, user, done). It does not. Instead the two param option is always called (user, done).
In the bearerstrategy jwtVerify function, self.passReqToCallback was being used instead of self._options.passReqToCallback. This cause the callback passed in to a new strategy to get called with the two param option even when "passReqToCallback" is set to true.