[AutoPR mgmt-v2016_10_01] [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview

sdk/keyvault/mgmt-v2016_10_01/pom.xml

@@ -11,15 +11,15 @@
     <parent>
         <groupId>com.microsoft.azure</groupId>
         <artifactId>azure-arm-parent</artifactId>
-        <version>1.3.0</version>
-        <relativePath>../../parents/azure-arm-parent</relativePath>
+        <version>1.1.0</version>
+        <relativePath>../../../pom.management.xml</relativePath>
     </parent>
     <artifactId>azure-mgmt-keyvault</artifactId>
-    <version>1.0.0-beta-2</version>
+    <version>1.0.0-beta</version>
     <packaging>jar</packaging>
     <name>Microsoft Azure SDK for KeyVault Management</name>
     <description>This package contains Microsoft KeyVault Management SDK.</description>
-    <url>https://github.com/Azure/azure-libraries-for-java</url>
+    <url>https://github.com/Azure/azure-sdk-for-java</url>
     <licenses>
         <license>
             <name>The MIT License (MIT)</name>
@@ -28,8 +28,8 @@
         </license>
     </licenses>
     <scm>
-        <url>scm:git:https://github.com/Azure/azure-libraries-for-java</url>
-        <connection>scm:git:git@github.com:Azure/azure-libraries-for-java.git</connection>
+        <url>scm:git:https://github.com/Azure/azure-sdk-for-java</url>
+        <connection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</connection>
         <tag>HEAD</tag>
     </scm>
     <properties>
@@ -71,6 +71,7 @@
             <artifactId>azure-arm-client-runtime</artifactId>
             <type>test-jar</type>
             <scope>test</scope>
+            <!--Below version for test jar needs to be removed, this will be done as part of v1-runtime 1.6.7-->
             <version>1.6.5</version>
         </dependency>
     </dependencies>

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/AccessPolicyEntry.java

@@ -44,7 +44,7 @@ public class AccessPolicyEntry {
     private Permissions permissions;
 
     /**
-     * Get the tenantId value.
+     * Get the Azure Active Directory tenant ID that should be used for authenticating requests to the key vault.
      *
      * @return the tenantId value
      */
@@ -53,7 +53,7 @@ public UUID tenantId() {
     }
 
     /**
-     * Set the tenantId value.
+     * Set the Azure Active Directory tenant ID that should be used for authenticating requests to the key vault.
      *
      * @param tenantId the tenantId value to set
      * @return the AccessPolicyEntry object itself.
@@ -64,7 +64,7 @@ public AccessPolicyEntry withTenantId(UUID tenantId) {
     }
 
     /**
-     * Get the objectId value.
+     * Get the object ID of a user, service principal or security group in the Azure Active Directory tenant for the vault. The object ID must be unique for the list of access policies.
      *
      * @return the objectId value
      */
@@ -73,7 +73,7 @@ public String objectId() {
     }
 
     /**
-     * Set the objectId value.
+     * Set the object ID of a user, service principal or security group in the Azure Active Directory tenant for the vault. The object ID must be unique for the list of access policies.
      *
      * @param objectId the objectId value to set
      * @return the AccessPolicyEntry object itself.
@@ -84,7 +84,7 @@ public AccessPolicyEntry withObjectId(String objectId) {
     }
 
     /**
-     * Get the applicationId value.
+     * Get application ID of the client making request on behalf of a principal.
      *
      * @return the applicationId value
      */
@@ -93,7 +93,7 @@ public UUID applicationId() {
     }
 
     /**
-     * Set the applicationId value.
+     * Set application ID of the client making request on behalf of a principal.
      *
      * @param applicationId the applicationId value to set
      * @return the AccessPolicyEntry object itself.
@@ -104,7 +104,7 @@ public AccessPolicyEntry withApplicationId(UUID applicationId) {
     }
 
     /**
-     * Get the permissions value.
+     * Get permissions the identity has for keys, secrets and certificates.
      *
      * @return the permissions value
      */
@@ -113,7 +113,7 @@ public Permissions permissions() {
     }
 
     /**
-     * Set the permissions value.
+     * Set permissions the identity has for keys, secrets and certificates.
      *
      * @param permissions the permissions value to set
      * @return the AccessPolicyEntry object itself.

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/DeletedVaultProperties.java

@@ -47,7 +47,7 @@ public class DeletedVaultProperties {
     private Map<String, String> tags;
 
     /**
-     * Get the vaultId value.
+     * Get the resource id of the original vault.
      *
      * @return the vaultId value
      */
@@ -56,7 +56,7 @@ public String vaultId() {
     }
 
     /**
-     * Get the location value.
+     * Get the location of the original vault.
      *
      * @return the location value
      */
@@ -65,7 +65,7 @@ public String location() {
     }
 
     /**
-     * Get the deletionDate value.
+     * Get the deleted date.
      *
      * @return the deletionDate value
      */
@@ -74,7 +74,7 @@ public DateTime deletionDate() {
     }
 
     /**
-     * Get the scheduledPurgeDate value.
+     * Get the scheduled purged date.
      *
      * @return the scheduledPurgeDate value
      */
@@ -83,7 +83,7 @@ public DateTime scheduledPurgeDate() {
     }
 
     /**
-     * Get the tags value.
+     * Get tags of the original vault.
      *
      * @return the tags value
      */

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/LogSpecification.java

@@ -33,7 +33,7 @@ public class LogSpecification {
     private String blobDuration;
 
     /**
-     * Get the name value.
+     * Get name of log specification.
      *
      * @return the name value
      */
@@ -42,7 +42,7 @@ public String name() {
     }
 
     /**
-     * Set the name value.
+     * Set name of log specification.
      *
      * @param name the name value to set
      * @return the LogSpecification object itself.
@@ -53,7 +53,7 @@ public LogSpecification withName(String name) {
     }
 
     /**
-     * Get the displayName value.
+     * Get display name of log specification.
      *
      * @return the displayName value
      */
@@ -62,7 +62,7 @@ public String displayName() {
     }
 
     /**
-     * Set the displayName value.
+     * Set display name of log specification.
      *
      * @param displayName the displayName value to set
      * @return the LogSpecification object itself.
@@ -73,7 +73,7 @@ public LogSpecification withDisplayName(String displayName) {
     }
 
     /**
-     * Get the blobDuration value.
+     * Get blob duration of specification.
      *
      * @return the blobDuration value
      */
@@ -82,7 +82,7 @@ public String blobDuration() {
     }
 
     /**
-     * Set the blobDuration value.
+     * Set blob duration of specification.
      *
      * @param blobDuration the blobDuration value to set
      * @return the LogSpecification object itself.

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/OperationDisplay.java

@@ -33,13 +33,13 @@ public class OperationDisplay {
     private String operation;
 
     /**
-     * Decription of operation.
+     * Description of operation.
      */
     @JsonProperty(value = "description")
     private String description;
 
     /**
-     * Get the provider value.
+     * Get service provider: Microsoft Key Vault.
      *
      * @return the provider value
      */
@@ -48,7 +48,7 @@ public String provider() {
     }
 
     /**
-     * Set the provider value.
+     * Set service provider: Microsoft Key Vault.
      *
      * @param provider the provider value to set
      * @return the OperationDisplay object itself.
@@ -59,7 +59,7 @@ public OperationDisplay withProvider(String provider) {
     }
 
     /**
-     * Get the resource value.
+     * Get resource on which the operation is performed etc.
      *
      * @return the resource value
      */
@@ -68,7 +68,7 @@ public String resource() {
     }
 
     /**
-     * Set the resource value.
+     * Set resource on which the operation is performed etc.
      *
      * @param resource the resource value to set
      * @return the OperationDisplay object itself.
@@ -79,7 +79,7 @@ public OperationDisplay withResource(String resource) {
     }
 
     /**
-     * Get the operation value.
+     * Get type of operation: get, read, delete, etc.
      *
      * @return the operation value
      */
@@ -88,7 +88,7 @@ public String operation() {
     }
 
     /**
-     * Set the operation value.
+     * Set type of operation: get, read, delete, etc.
      *
      * @param operation the operation value to set
      * @return the OperationDisplay object itself.
@@ -99,7 +99,7 @@ public OperationDisplay withOperation(String operation) {
     }
 
     /**
-     * Get the description value.
+     * Get description of operation.
      *
      * @return the description value
      */
@@ -108,7 +108,7 @@ public String description() {
     }
 
     /**
-     * Set the description value.
+     * Set description of operation.
      *
      * @param description the description value to set
      * @return the OperationDisplay object itself.

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/Permissions.java

@@ -40,7 +40,7 @@ public class Permissions {
     private List<StoragePermissions> storage;
 
     /**
-     * Get the keys value.
+     * Get permissions to keys.
      *
      * @return the keys value
      */
@@ -49,7 +49,7 @@ public List<KeyPermissions> keys() {
     }
 
     /**
-     * Set the keys value.
+     * Set permissions to keys.
      *
      * @param keys the keys value to set
      * @return the Permissions object itself.
@@ -60,7 +60,7 @@ public Permissions withKeys(List<KeyPermissions> keys) {
     }
 
     /**
-     * Get the secrets value.
+     * Get permissions to secrets.
      *
      * @return the secrets value
      */
@@ -69,7 +69,7 @@ public List<SecretPermissions> secrets() {
     }
 
     /**
-     * Set the secrets value.
+     * Set permissions to secrets.
      *
      * @param secrets the secrets value to set
      * @return the Permissions object itself.
@@ -80,7 +80,7 @@ public Permissions withSecrets(List<SecretPermissions> secrets) {
     }
 
     /**
-     * Get the certificates value.
+     * Get permissions to certificates.
      *
      * @return the certificates value
      */
@@ -89,7 +89,7 @@ public List<CertificatePermissions> certificates() {
     }
 
     /**
-     * Set the certificates value.
+     * Set permissions to certificates.
      *
      * @param certificates the certificates value to set
      * @return the Permissions object itself.
@@ -100,7 +100,7 @@ public Permissions withCertificates(List<CertificatePermissions> certificates) {
     }
 
     /**
-     * Get the storage value.
+     * Get permissions to storage accounts.
      *
      * @return the storage value
      */
@@ -109,7 +109,7 @@ public List<StoragePermissions> storage() {
     }
 
     /**
-     * Set the storage value.
+     * Set permissions to storage accounts.
      *
      * @param storage the storage value to set
      * @return the Permissions object itself.

sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/ServiceSpecification.java

@@ -22,7 +22,7 @@ public class ServiceSpecification {
     private List<LogSpecification> logSpecifications;
 
     /**
-     * Get the logSpecifications value.
+     * Get log specifications of operation.
      *
      * @return the logSpecifications value
      */
@@ -31,7 +31,7 @@ public List<LogSpecification> logSpecifications() {
     }
 
     /**
-     * Set the logSpecifications value.
+     * Set log specifications of operation.
      *
      * @param logSpecifications the logSpecifications value to set
      * @return the ServiceSpecification object itself.