[Lint] fixing low hanging fruit linter warnings (Azure#13856)

AzureSDKAutomation · Feb 18, 2021 · 38a2bdd · 38a2bdd
1 parent 350612d
commit 38a2bdd
Show file tree

Hide file tree

Showing 10 changed files with 24 additions and 15 deletions.
diff --git a/...ication/communication-administration/review/communication-administration.api.md b/...ication/communication-administration/review/communication-administration.api.md
@@ -495,7 +495,7 @@ export interface UpdatePhoneNumberCapabilitiesResponse {
 }
 
 // @public
-export type VoidResponse = WithResponse<{}>;
+export type VoidResponse = WithResponse<Record<string, unknown>>;
 
 // @public
 export type WithResponse<T> = T & {

diff --git a/sdk/communication/communication-administration/src/common/models.ts b/sdk/communication/communication-administration/src/common/models.ts
@@ -12,4 +12,4 @@ export type WithResponse<T> = T & { _response: HttpResponse };
 /**
  * Represents a generic HTTP response
  */
-export type VoidResponse = WithResponse<{}>;
+export type VoidResponse = WithResponse<Record<string, unknown>>;
diff --git a/sdk/communication/communication-administration/src/phoneNumber/lro/purchase/operation.ts b/sdk/communication/communication-administration/src/phoneNumber/lro/purchase/operation.ts
@@ -90,10 +90,12 @@ export class PurchaseReservationPollOperation extends PhoneNumberReservationPoll
         const result = await this.getReservation(reservationId, this.requestOptions);
         state.isCompleted = isComplete(result, "Success");
       }
+
+      return this;
     } catch (error) {
       state.error = error;
       state.isCompleted = true;
-    } finally {
+
       return this;
     }
   }

diff --git a/sdk/communication/communication-administration/src/phoneNumber/lro/release/operation.ts b/sdk/communication/communication-administration/src/phoneNumber/lro/release/operation.ts
@@ -129,10 +129,12 @@ export class ReleasePhoneNumbersPollOperation extends PhoneNumberPollOperationBa
         state.result = await this.getRelease(state.releaseId, this.requestOptions);
         state.isCompleted = isComplete(state.result, "Complete");
       }
+
+      return this;
     } catch (error) {
       state.error = error;
       state.isCompleted = true;
-    } finally {
+
       return this;
     }
   }

diff --git a/sdk/communication/communication-administration/src/phoneNumber/lro/reserve/operation.ts b/sdk/communication/communication-administration/src/phoneNumber/lro/reserve/operation.ts
@@ -107,10 +107,12 @@ export class ReservePhoneNumbersPollOperation extends PhoneNumberReservationPoll
         state.result = await this.getReservation(state.reservationId, this.requestOptions);
         state.isCompleted = isComplete(state.result, "Reserved");
       }
+
+      return this;
     } catch (error) {
       state.error = error;
       state.isCompleted = true;
-    } finally {
+
       return this;
     }
   }

diff --git a/...unication/communication-administration/src/phoneNumber/phoneNumberAdministrationClient.ts b/...unication/communication-administration/src/phoneNumber/phoneNumberAdministrationClient.ts
@@ -931,7 +931,7 @@ export class PhoneNumberAdministrationClient {
    * for await (const phonePlan of client.listPhonePlanGroups(PLAN_GROUP_INFO)) {
    *   console.log("plan id: ", phonePlan.phonePlanId);
    * }
-   *
+   * ```
    * Gets all available phone plans for a given plan group.
    * @param planGroupInfo - Information need to search for plans.
    * @param options - Additional request options.

diff --git a/sdk/communication/communication-administration/test/lro.purchase.spec.ts b/sdk/communication/communication-administration/test/lro.purchase.spec.ts
@@ -44,7 +44,7 @@ describe("PhoneNumber - LROs - Purchase Reservation [Playback/Live]", function()
 
     let phonePlanGroupId: string = "";
     for await (const phonePlanGroup of client.listPhonePlanGroups(countryCode)) {
-      if (phonePlanGroup.phoneNumberType == "Geographic") {
+      if (phonePlanGroup.phoneNumberType === "Geographic") {
         assert.isString(phonePlanGroup.phonePlanGroupId);
         ({ phonePlanGroupId } = phonePlanGroup);
         break;

diff --git a/sdk/communication/communication-administration/test/lro.reserve.spec.ts b/sdk/communication/communication-administration/test/lro.reserve.spec.ts
@@ -46,7 +46,7 @@ describe("PhoneNumber - LROs - Phone Number Reservations [Playback/Live]", funct
 
     let phonePlanGroupId: string = "";
     for await (const phonePlanGroup of client.listPhonePlanGroups(countryCode)) {
-      if (phonePlanGroup.phoneNumberType == "Geographic") {
+      if (phonePlanGroup.phoneNumberType === "Geographic") {
         assert.isString(phonePlanGroup.phonePlanGroupId);
         ({ phonePlanGroupId } = phonePlanGroup);
         assert.isString(phonePlanGroupId);

diff --git a/sdk/communication/communication-administration/test/utils/mockHttpClients.ts b/sdk/communication/communication-administration/test/utils/mockHttpClients.ts
@@ -17,7 +17,10 @@ import {
   UpdateNumberCapabilitiesResponse
 } from "../../src";
 
-export const createMockHttpClient = <T = {}>(status: number = 200, parsedBody?: T): HttpClient => {
+export const createMockHttpClient = <T = Record<string, unknown>>(
+  status: number = 200,
+  parsedBody?: T
+): HttpClient => {
   return {
     async sendRequest(httpRequest: WebResourceLike): Promise<HttpOperationResponse> {
       return {

diff --git a/sdk/communication/communication-administration/test/utils/recordedClient.ts b/sdk/communication/communication-administration/test/utils/recordedClient.ts
@@ -38,16 +38,16 @@ export const environmentSetup: RecorderEnvironmentSetup = {
   customizationsOnRecordings: [
     (recording: string): string =>
       recording.replace(/"token"\s?:\s?"[^"]*"/g, `"token":"sanitized"`),
-    (recording: string): string => recording.replace(/(https:\/\/)([^\/',]*)/, "$1endpoint"),
+    (recording: string): string => recording.replace(/(https:\/\/)([^/',]*)/, "$1endpoint"),
     (recording: string): string => recording.replace(/"id"\s?:\s?"[^"]*"/g, `"id":"sanitized"`),
     (recording: string): string => {
       return recording.replace(
-        /(https:\/\/[^\/',]*\/identities\/)[^\/',]*(\/token)/,
+        /(https:\/\/[^/',]*\/identities\/)[^/',]*(\/token)/,
         "$1sanitized$2"
       );
     },
     (recording: string): string =>
-      recording.replace(/\/identities\/[^\/'",]*/, "/identities/sanitized"),
+      recording.replace(/\/identities\/[^/'",]*/, "/identities/sanitized"),
     (recording: string): string => recording.replace(/\+\d{1}\d{3}\d{3}\d{4}/g, "+18005551234"),
     (recording: string): string =>
       recording.replace(/[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}/gi, "sanitized")
@@ -65,7 +65,7 @@ export function createRecordedPhoneNumberAdministrationClient(
   return {
     client: new PhoneNumberAdministrationClient(env.COMMUNICATION_CONNECTION_STRING),
     recorder,
-    includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS == "true"
+    includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS === "true"
   };
 }
 
@@ -90,7 +90,7 @@ export function createRecordedPhoneNumberAdministrationClientWithToken(
     return {
       client: new PhoneNumberAdministrationClient(endpoint, credential),
       recorder,
-      includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS == "true"
+      includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS === "true"
     };
   }
 
@@ -103,7 +103,7 @@ export function createRecordedPhoneNumberAdministrationClientWithToken(
   return {
     client: new PhoneNumberAdministrationClient(endpoint, credential),
     recorder,
-    includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS == "true"
+    includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS === "true"
   };
 }