Revert "Make tag as optional (Azure#14427)" (Azure#14766)

- Azure#14427 appears to cause all packages to be published with no tags. - This reverts commit 74a6162.
AzureSDKAutomation · Apr 7, 2021 · b2e23e3 · b2e23e3
1 parent c269edf
commit b2e23e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/eng/pipelines/templates/stages/archetype-js-release.yml b/eng/pipelines/templates/stages/archetype-js-release.yml
@@ -85,7 +85,7 @@ stages:
                         inputs:
                           targetType: filePath
                           filePath: "eng/tools/publish-to-npm.ps1"
-                          arguments: '-pathToArtifacts $(Package.Archive) -accessLevel "public" -tag $env:Tag -additionalTag $env:AdditionalTag -registry ${{parameters.Registry}} -npmToken $(azure-sdk-npm-token)'
+                          arguments: '-pathToArtifacts $(Package.Archive) -accessLevel "public" -tag $(Tag) -additionalTag "$(AdditionalTag)" -registry ${{parameters.Registry}} -npmToken $(azure-sdk-npm-token)'
                           pwsh: true
 
           - ${{if ne(artifact.skipPublishDocMs, 'true')}}:

diff --git a/eng/tools/publish-to-npm.ps1 b/eng/tools/publish-to-npm.ps1
@@ -1,7 +1,7 @@
 param (
   $pathToArtifacts,
   $accessLevel,
-  $tag="",
+  $tag,
   $additionalTag="",
   $registry,
   $npmToken,
@@ -125,17 +125,8 @@ try {
 
     foreach ($p in $packageList) {
         if($p.Publish) {
-            if ($tag)
-            {
-              Write-Host "npm publish $($p.TarGz) --access=$accessLevel --registry=$registry --always-auth=true --tag=$tag"
-              npm publish $p.TarGz --access=$accessLevel --registry=$registry --always-auth=true --tag=$tag
-            }
-            else
-            {
-              Write-Host "npm publish $($p.TarGz) --access=$accessLevel --registry=$registry --always-auth=true"
-              npm publish $p.TarGz --access=$accessLevel --registry=$registry --always-auth=true
-            }
-
+            Write-Host "npm publish $($p.TarGz) --access=$accessLevel --registry=$registry --always-auth=true --tag=$tag"
+            npm publish $p.TarGz --access=$accessLevel --registry=$registry --always-auth=true --tag=$tag
             if ($LastExitCode -ne 0) {
                 Write-Host "npm publish failed with exit code $LastExitCode"
                 exit 1