CodeGen from PR 18078 in Azure/azure-rest-api-specs

update-ascLocation-x-ms-parameter-location-for-datacatalog (Azure#18078)
AzureSDKAutomation · Mar 4, 2022 · cfa8003 · cfa8003
1 parent d4f1078
commit cfa8003
Show file tree

Hide file tree

Showing 10 changed files with 102 additions and 47 deletions.
diff --git a/sdk/datacatalog/arm-datacatalog/CHANGELOG.md b/sdk/datacatalog/arm-datacatalog/CHANGELOG.md
@@ -1,5 +1,18 @@
 # Release History
 
+## 4.0.0 (2022-03-04)
+
+**Breaking Changes**
+
+  - Operation ADCCatalogs.beginDelete has a new signature
+  - Operation ADCCatalogs.beginDeleteAndWait has a new signature
+  - Operation ADCCatalogs.createOrUpdate has a new signature
+  - Operation ADCCatalogs.get has a new signature
+  - Operation ADCCatalogs.update has a new signature
+  - Class DataCatalogRestClient has a new signature
+  - Class DataCatalogRestClient no longer has parameter catalogName
+
+
 ## 3.0.0 (2022-01-21)
 
 The package of @azure/arm-datacatalog is using our next generation design principles since version 3.0.0, which contains breaking changes.

diff --git a/sdk/datacatalog/arm-datacatalog/_meta.json b/sdk/datacatalog/arm-datacatalog/_meta.json
@@ -1,7 +1,7 @@
 {
-  "commit": "f9a6cb686bcc0f1b23761db19f2491c5c4df95cb",
+  "commit": "89189f055405d20bc3a97c70266f934f06c3bb12",
   "readme": "specification/datacatalog/resource-manager/readme.md",
-  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/datacatalog/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220114.1",
+  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/datacatalog/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "use": "@autorest/typescript@6.0.0-alpha.16.20220114.1"
+  "use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
 }
diff --git a/sdk/datacatalog/arm-datacatalog/api-extractor.json b/sdk/datacatalog/arm-datacatalog/api-extractor.json
@@ -1,18 +1,31 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
   "mainEntryPointFilePath": "./dist-esm/src/index.d.ts",
-  "docModel": { "enabled": true },
-  "apiReport": { "enabled": true, "reportFolder": "./review" },
+  "docModel": {
+    "enabled": true
+  },
+  "apiReport": {
+    "enabled": true,
+    "reportFolder": "./review"
+  },
   "dtsRollup": {
     "enabled": true,
     "untrimmedFilePath": "",
     "publicTrimmedFilePath": "./types/arm-datacatalog.d.ts"
   },
   "messages": {
-    "tsdocMessageReporting": { "default": { "logLevel": "none" } },
+    "tsdocMessageReporting": {
+      "default": {
+        "logLevel": "none"
+      }
+    },
     "extractorMessageReporting": {
-      "ae-missing-release-tag": { "logLevel": "none" },
-      "ae-unresolved-link": { "logLevel": "none" }
+      "ae-missing-release-tag": {
+        "logLevel": "none"
+      },
+      "ae-unresolved-link": {
+        "logLevel": "none"
+      }
     }
   }
-}
+}
diff --git a/sdk/datacatalog/arm-datacatalog/package.json b/sdk/datacatalog/arm-datacatalog/package.json
@@ -3,8 +3,10 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for DataCatalogRestClient.",
-  "version": "3.0.0",
-  "engines": { "node": ">=12.0.0" },
+  "version": "1.0.0-beta.1",
+  "engines": {
+    "node": ">=12.0.0"
+  },
   "dependencies": {
     "@azure/core-lro": "^2.2.0",
     "@azure/abort-controller": "^1.0.0",
@@ -13,7 +15,13 @@
     "@azure/core-rest-pipeline": "^1.1.0",
     "tslib": "^2.2.0"
   },
-  "keywords": ["node", "azure", "typescript", "browser", "isomorphic"],
+  "keywords": [
+    "node",
+    "azure",
+    "typescript",
+    "browser",
+    "isomorphic"
+  ],
   "license": "MIT",
   "main": "./dist/index.js",
   "module": "./dist-esm/src/index.js",
@@ -40,7 +48,9 @@
     "type": "git",
     "url": "https://github.com/Azure/azure-sdk-for-js.git"
   },
-  "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" },
+  "bugs": {
+    "url": "https://github.com/Azure/azure-sdk-for-js/issues"
+  },
   "files": [
     "dist/**/*.js",
     "dist/**/*.js.map",
@@ -87,10 +97,5 @@
     "docs": "echo skipped"
   },
   "sideEffects": false,
-  "//metadata": {
-    "constantPaths": [
-      { "path": "src/DataCatalogRestClient.ts", "prefix": "packageDetails" }
-    ]
-  },
   "autoPublish": true
-}
+}
diff --git a/sdk/datacatalog/arm-datacatalog/review/arm-datacatalog.api.md b/sdk/datacatalog/arm-datacatalog/review/arm-datacatalog.api.md
@@ -21,12 +21,12 @@ export type ADCCatalog = Resource & {
 
 // @public
 export interface ADCCatalogs {
-    beginDelete(resourceGroupName: string, options?: ADCCatalogsDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
-    beginDeleteAndWait(resourceGroupName: string, options?: ADCCatalogsDeleteOptionalParams): Promise<void>;
-    createOrUpdate(resourceGroupName: string, properties: ADCCatalog, options?: ADCCatalogsCreateOrUpdateOptionalParams): Promise<ADCCatalogsCreateOrUpdateResponse>;
-    get(resourceGroupName: string, options?: ADCCatalogsGetOptionalParams): Promise<ADCCatalogsGetResponse>;
+    beginDelete(resourceGroupName: string, catalogName: string, options?: ADCCatalogsDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
+    beginDeleteAndWait(resourceGroupName: string, catalogName: string, options?: ADCCatalogsDeleteOptionalParams): Promise<void>;
+    createOrUpdate(resourceGroupName: string, catalogName: string, properties: ADCCatalog, options?: ADCCatalogsCreateOrUpdateOptionalParams): Promise<ADCCatalogsCreateOrUpdateResponse>;
+    get(resourceGroupName: string, catalogName: string, options?: ADCCatalogsGetOptionalParams): Promise<ADCCatalogsGetResponse>;
     listtByResourceGroup(resourceGroupName: string, options?: ADCCatalogsListtByResourceGroupOptionalParams): Promise<ADCCatalogsListtByResourceGroupResponse>;
-    update(resourceGroupName: string, properties: ADCCatalog, options?: ADCCatalogsUpdateOptionalParams): Promise<ADCCatalogsUpdateResponse>;
+    update(resourceGroupName: string, catalogName: string, properties: ADCCatalog, options?: ADCCatalogsUpdateOptionalParams): Promise<ADCCatalogsUpdateResponse>;
 }
 
 // @public
@@ -84,16 +84,14 @@ export type ADCOperationsListResponse = OperationEntityListResult;
 export class DataCatalogRestClient extends coreClient.ServiceClient {
     // (undocumented)
     $host: string;
-    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, catalogName: string, options?: DataCatalogRestClientOptionalParams);
+    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, options?: DataCatalogRestClientOptionalParams);
     // (undocumented)
     aDCCatalogs: ADCCatalogs;
     // (undocumented)
     aDCOperations: ADCOperations;
     // (undocumented)
     apiVersion: string;
     // (undocumented)
-    catalogName: string;
-    // (undocumented)
     subscriptionId: string;
 }
 

diff --git a/sdk/datacatalog/arm-datacatalog/src/dataCatalogRestClient.ts b/sdk/datacatalog/arm-datacatalog/src/dataCatalogRestClient.ts
@@ -16,20 +16,17 @@ export class DataCatalogRestClient extends coreClient.ServiceClient {
   $host: string;
   apiVersion: string;
   subscriptionId: string;
-  catalogName: string;
 
   /**
    * Initializes a new instance of the DataCatalogRestClient class.
    * @param credentials Subscription credentials which uniquely identify client subscription.
    * @param subscriptionId Gets subscription credentials which uniquely identify the Microsoft Azure
    *                       subscription. The subscription ID forms part of the URI for every service call.
-   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The parameter options
    */
   constructor(
     credentials: coreAuth.TokenCredential,
     subscriptionId: string,
-    catalogName: string,
     options?: DataCatalogRestClientOptionalParams
   ) {
     if (credentials === undefined) {
@@ -38,9 +35,6 @@ export class DataCatalogRestClient extends coreClient.ServiceClient {
     if (subscriptionId === undefined) {
       throw new Error("'subscriptionId' cannot be null");
     }
-    if (catalogName === undefined) {
-      throw new Error("'catalogName' cannot be null");
-    }
 
     // Initializing default values for options
     if (!options) {
@@ -51,7 +45,7 @@ export class DataCatalogRestClient extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-datacatalog/3.0.0`;
+    const packageDetails = `azsdk-js-arm-datacatalog/4.0.0`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
@@ -71,7 +65,6 @@ export class DataCatalogRestClient extends coreClient.ServiceClient {
     super(optionsWithDefaults);
     // Parameter assignments
     this.subscriptionId = subscriptionId;
-    this.catalogName = catalogName;
 
     // Assigning values to Constant parameters
     this.$host = options.$host || "https://management.azure.com";

diff --git a/sdk/datacatalog/arm-datacatalog/src/operations/aDCCatalogs.ts b/sdk/datacatalog/arm-datacatalog/src/operations/aDCCatalogs.ts
@@ -61,16 +61,18 @@ export class ADCCatalogsImpl implements ADCCatalogs {
    * updated and any immutable properties will remain unchanged.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param properties Properties supplied to the Create or Update a data catalog.
    * @param options The options parameters.
    */
   createOrUpdate(
     resourceGroupName: string,
+    catalogName: string,
     properties: ADCCatalog,
     options?: ADCCatalogsCreateOrUpdateOptionalParams
   ): Promise<ADCCatalogsCreateOrUpdateResponse> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, properties, options },
+      { resourceGroupName, catalogName, properties, options },
       createOrUpdateOperationSpec
     );
   }
@@ -79,14 +81,16 @@ export class ADCCatalogsImpl implements ADCCatalogs {
    * The Get Azure Data Catalog Service operation retrieves a json representation of the data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   get(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsGetOptionalParams
   ): Promise<ADCCatalogsGetResponse> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, options },
+      { resourceGroupName, catalogName, options },
       getOperationSpec
     );
   }
@@ -95,10 +99,12 @@ export class ADCCatalogsImpl implements ADCCatalogs {
    * The Delete Azure Data Catalog Service operation deletes an existing data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   async beginDelete(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsDeleteOptionalParams
   ): Promise<PollerLike<PollOperationState<void>, void>> {
     const directSendOperation = async (
@@ -142,7 +148,7 @@ export class ADCCatalogsImpl implements ADCCatalogs {
 
     const lro = new LroImpl(
       sendOperation,
-      { resourceGroupName, options },
+      { resourceGroupName, catalogName, options },
       deleteOperationSpec
     );
     return new LroEngine(lro, {
@@ -155,13 +161,19 @@ export class ADCCatalogsImpl implements ADCCatalogs {
    * The Delete Azure Data Catalog Service operation deletes an existing data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   async beginDeleteAndWait(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsDeleteOptionalParams
   ): Promise<void> {
-    const poller = await this.beginDelete(resourceGroupName, options);
+    const poller = await this.beginDelete(
+      resourceGroupName,
+      catalogName,
+      options
+    );
     return poller.pollUntilDone();
   }
 
@@ -170,16 +182,18 @@ export class ADCCatalogsImpl implements ADCCatalogs {
    * update call only supports the properties listed in the PATCH body.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param properties Properties supplied to the Update a data catalog.
    * @param options The options parameters.
    */
   update(
     resourceGroupName: string,
+    catalogName: string,
     properties: ADCCatalog,
     options?: ADCCatalogsUpdateOptionalParams
   ): Promise<ADCCatalogsUpdateResponse> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, properties, options },
+      { resourceGroupName, catalogName, properties, options },
       updateOperationSpec
     );
   }

diff --git a/sdk/datacatalog/arm-datacatalog/src/operationsInterfaces/aDCCatalogs.ts b/sdk/datacatalog/arm-datacatalog/src/operationsInterfaces/aDCCatalogs.ts
@@ -39,54 +39,64 @@ export interface ADCCatalogs {
    * updated and any immutable properties will remain unchanged.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param properties Properties supplied to the Create or Update a data catalog.
    * @param options The options parameters.
    */
   createOrUpdate(
     resourceGroupName: string,
+    catalogName: string,
     properties: ADCCatalog,
     options?: ADCCatalogsCreateOrUpdateOptionalParams
   ): Promise<ADCCatalogsCreateOrUpdateResponse>;
   /**
    * The Get Azure Data Catalog Service operation retrieves a json representation of the data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   get(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsGetOptionalParams
   ): Promise<ADCCatalogsGetResponse>;
   /**
    * The Delete Azure Data Catalog Service operation deletes an existing data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   beginDelete(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsDeleteOptionalParams
   ): Promise<PollerLike<PollOperationState<void>, void>>;
   /**
    * The Delete Azure Data Catalog Service operation deletes an existing data catalog.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param options The options parameters.
    */
   beginDeleteAndWait(
     resourceGroupName: string,
+    catalogName: string,
     options?: ADCCatalogsDeleteOptionalParams
   ): Promise<void>;
   /**
    * The Update Azure Data Catalog Service operation can be used to update the existing deployment. The
    * update call only supports the properties listed in the PATCH body.
    * @param resourceGroupName The name of the resource group within the user's subscription. The name is
    *                          case insensitive.
+   * @param catalogName The name of the data catalog in the specified subscription and resource group.
    * @param properties Properties supplied to the Update a data catalog.
    * @param options The options parameters.
    */
   update(
     resourceGroupName: string,
+    catalogName: string,
     properties: ADCCatalog,
     options?: ADCCatalogsUpdateOptionalParams
   ): Promise<ADCCatalogsUpdateResponse>;

diff --git a/sdk/datacatalog/arm-datacatalog/tsconfig.json b/sdk/datacatalog/arm-datacatalog/tsconfig.json
@@ -9,11 +9,19 @@
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
-    "lib": ["es6", "dom"],
+    "lib": [
+      "es6",
+      "dom"
+    ],
     "declaration": true,
     "outDir": "./dist-esm",
     "importHelpers": true
   },
-  "include": ["./src/**/*.ts", "./test/**/*.ts"],
-  "exclude": ["node_modules"]
-}
+  "include": [
+    "./src/**/*.ts",
+    "./test/**/*.ts"
+  ],
+  "exclude": [
+    "node_modules"
+  ]
+}