Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-advisor] typo: suppresion -> suppression #3334

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/advisor/arm-advisor/LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2020 Microsoft
Copyright (c) 2021 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
9 changes: 4 additions & 5 deletions sdk/advisor/arm-advisor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ npm install @azure/arm-advisor

### How to use

#### nodejs - Authentication, client creation and get recommendationMetadata as an example written in TypeScript.
#### nodejs - client creation and get recommendationMetadata as an example written in TypeScript.

##### Install @azure/ms-rest-nodeauth

Expand All @@ -26,11 +26,10 @@ npm install @azure/ms-rest-nodeauth@"^3.0.0"

##### Sample code

While the below sample uses the interactive login, other authentication options can be found in the [README.md file of @azure/ms-rest-nodeauth](https://www.npmjs.com/package/@azure/ms-rest-nodeauth) package
```typescript
import * as msRest from "@azure/ms-rest-js";
import * as msRestAzure from "@azure/ms-rest-azure-js";
import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
import { AdvisorManagementClient, AdvisorManagementModels, AdvisorManagementMappers } from "@azure/arm-advisor";
const msRestNodeAuth = require("@azure/ms-rest-nodeauth");
const { AdvisorManagementClient } = require("@azure/arm-advisor");
const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];

msRestNodeAuth.interactiveLogin().then((creds) => {
Expand Down
4 changes: 2 additions & 2 deletions sdk/advisor/arm-advisor/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ const config = {
"@azure/ms-rest-azure-js": "msRestAzure"
},
banner: `/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down
5 changes: 2 additions & 3 deletions sdk/advisor/arm-advisor/src/advisorManagementClient.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down
4 changes: 2 additions & 2 deletions sdk/advisor/arm-advisor/src/models/configurationsMappers.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down
67 changes: 60 additions & 7 deletions sdk/advisor/arm-advisor/src/models/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down Expand Up @@ -288,14 +288,43 @@ export interface SuppressionContract extends Resource {
* The duration for which the suppression is valid.
*/
ttl?: string;
/**
* Gets or sets the expiration time stamp.
* **NOTE: This property will not be serialized. It can only be populated by the server.**
*/
readonly expirationTimeStamp?: Date;
}

/**
* Optional Parameters.
*/
export interface RecommendationsListOptionalParams extends msRest.RequestOptionsBase {
/**
* The filter to apply to the recommendations.
* The filter to apply to the recommendations.<br>Filter can be applied to properties
* ['ResourceId', 'ResourceGroup', 'RecommendationTypeGuid', '[Category](#category)'] with
* operators ['eq', 'and', 'or'].<br>Example:<br>- $filter=Category eq 'Cost' and ResourceGroup
* eq 'MyResourceGroup'
*/
filter?: string;
/**
* The number of recommendations per page if a paged version of this API is being used.
*/
top?: number;
/**
* The page-continuation token to use with a paged version of this API.
*/
skipToken?: string;
}

/**
* Optional Parameters.
*/
export interface RecommendationsListNextOptionalParams extends msRest.RequestOptionsBase {
/**
* The filter to apply to the recommendations.<br>Filter can be applied to properties
* ['ResourceId', 'ResourceGroup', 'RecommendationTypeGuid', '[Category](#category)'] with
* operators ['eq', 'and', 'or'].<br>Example:<br>- $filter=Category eq 'Cost' and ResourceGroup
* eq 'MyResourceGroup'
*/
filter?: string;
/**
Expand All @@ -322,6 +351,20 @@ export interface SuppressionsListOptionalParams extends msRest.RequestOptionsBas
skipToken?: string;
}

/**
* Optional Parameters.
*/
export interface SuppressionsListNextOptionalParams extends msRest.RequestOptionsBase {
/**
* The number of suppressions per page if a paged version of this API is being used.
*/
top?: number;
/**
* The page-continuation token to use with a paged version of this API.
*/
skipToken?: string;
}

/**
* An interface representing AdvisorManagementClientOptions.
*/
Expand Down Expand Up @@ -736,7 +779,12 @@ export type OperationsListNextResponse = OperationEntityListResult & {
/**
* Contains response data for the get operation.
*/
export type SuppressionsGetResponse = SuppressionContract & {
export type SuppressionsGetResponse = {
/**
* The parsed response body.
*/
body: any;

/**
* The underlying HTTP response.
*/
Expand All @@ -749,14 +797,19 @@ export type SuppressionsGetResponse = SuppressionContract & {
/**
* The response body as parsed JSON or XML
*/
parsedBody: SuppressionContract;
parsedBody: any;
};
};

/**
* Contains response data for the create operation.
*/
export type SuppressionsCreateResponse = SuppressionContract & {
export type SuppressionsCreateResponse = {
/**
* The parsed response body.
*/
body: any;

/**
* The underlying HTTP response.
*/
Expand All @@ -769,7 +822,7 @@ export type SuppressionsCreateResponse = SuppressionContract & {
/**
* The response body as parsed JSON or XML
*/
parsedBody: SuppressionContract;
parsedBody: any;
};
};

Expand Down
11 changes: 9 additions & 2 deletions sdk/advisor/arm-advisor/src/models/mappers.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
Expand Down Expand Up @@ -477,6 +477,13 @@ export const SuppressionContract: msRest.CompositeMapper = {
type: {
name: "String"
}
},
expirationTimeStamp: {
readOnly: true,
serializedName: "properties.expirationTimeStamp",
type: {
name: "DateTime"
}
}
}
}
Expand Down
7 changes: 4 additions & 3 deletions sdk/advisor/arm-advisor/src/models/operationsMappers.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

export {
CloudError,
ArmErrorResponse,
ARMErrorResponseBody,
OperationDisplayInfo,
OperationEntity,
OperationEntityListResult
Expand Down
5 changes: 2 additions & 3 deletions sdk/advisor/arm-advisor/src/models/parameters.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

export {
ArmErrorResponse,
ARMErrorResponseBody,
CloudError,
MetadataEntity,
MetadataEntityListResult,
MetadataSupportedValueDetail
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

export {
ArmErrorResponse,
ARMErrorResponseBody,
BaseResource,
CloudError,
ConfigData,
DigestConfig,
RecommendationsGenerateHeaders,
Expand Down
7 changes: 4 additions & 3 deletions sdk/advisor/arm-advisor/src/models/suppressionsMappers.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

export {
ArmErrorResponse,
ARMErrorResponseBody,
BaseResource,
CloudError,
ConfigData,
DigestConfig,
Resource,
Expand Down
8 changes: 5 additions & 3 deletions sdk/advisor/arm-advisor/src/operations/configurations.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down Expand Up @@ -292,6 +291,9 @@ const listBySubscriptionNextOperationSpec: msRest.OperationSpec = {
urlParameters: [
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion
],
headerParameters: [
Parameters.acceptLanguage
],
Expand Down
5 changes: 2 additions & 3 deletions sdk/advisor/arm-advisor/src/operations/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down
12 changes: 7 additions & 5 deletions sdk/advisor/arm-advisor/src/operations/operations.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
Expand Down Expand Up @@ -95,7 +94,7 @@ const listOperationSpec: msRest.OperationSpec = {
bodyMapper: Mappers.OperationEntityListResult
},
default: {
bodyMapper: Mappers.CloudError
bodyMapper: Mappers.ArmErrorResponse
}
},
serializer
Expand All @@ -108,6 +107,9 @@ const listNextOperationSpec: msRest.OperationSpec = {
urlParameters: [
Parameters.nextPageLink
],
queryParameters: [
Parameters.apiVersion
],
headerParameters: [
Parameters.acceptLanguage
],
Expand All @@ -116,7 +118,7 @@ const listNextOperationSpec: msRest.OperationSpec = {
bodyMapper: Mappers.OperationEntityListResult
},
default: {
bodyMapper: Mappers.CloudError
bodyMapper: Mappers.ArmErrorResponse
}
},
serializer
Expand Down
Loading