Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-batch] Azure Batch updated to 2021-06-01.14 #5107

Closed
wants to merge 41 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d769b84
Change default branch name to main (#15840)
praveenkuttappan Jun 18, 2021
1d0b3dd
Fix hard-coded master (#15843)
azure-sdk Jun 18, 2021
ddf4714
[Communication]: Always use x-ms-date for Hmac (#15807)
JianpingChen Jun 18, 2021
c075155
Automatic rush update recheck (#15839)
azure-sdk Jun 18, 2021
bdff63d
[KeyVault] - Add networkAcls to MHSM ARM template (#15830)
maorleger Jun 18, 2021
d023204
[Core] - Move core-tracing to @opentelemetry/api 0.20.0 (#15672)
maorleger Jun 18, 2021
37d1df4
arm-support-identity (#15838)
colawwj Jun 21, 2021
4471210
[identity] Adding extensions API, identity-vscode, and identity-cache…
witemple-msft Jun 21, 2021
919e856
[AzureMonitorExporter] Adding support for temporary redirect (#15850)
hectorhdzg Jun 21, 2021
f9efdf4
Package artifact path (#15512)
praveenkuttappan Jun 21, 2021
d4d2c75
[service-bus] Closing some open areas where we could mask errors, and…
richardpark-msft Jun 21, 2021
5da2922
Sync eng/common directory with azure-sdk-tools for PR 1716 (#15876)
azure-sdk Jun 21, 2021
450f924
Sync eng/common directory with azure-sdk-tools for PR 1719 (#15885)
azure-sdk Jun 21, 2021
b26a218
Remove core-lro runtime dependency on core-http (#15884)
xirzec Jun 22, 2021
53d6089
[Identity] Comment improvements. Identity generally doesn't return nu…
sadasant Jun 22, 2021
8ab9b83
[Identity] README.md: Bigger title for Extensions and a markdown fix …
sadasant Jun 22, 2021
ac8d65c
[core] Update @azure/core-tracing to use @opentelemetry/api@1.0.0 (#1…
maorleger Jun 22, 2021
a64747c
Rename hardcoded master links to use main
chidozieononiwu Jun 22, 2021
bf5cd3e
[App Config] Add display_name to FeatureFlag (#15901)
HarshaNalluru Jun 22, 2021
0f4ae0c
[identity] Add publication metadata for extension pacakges (#15900)
witemple-msft Jun 22, 2021
c7f3a2a
Replace master with main in homepage links.
witemple-msft Jun 22, 2021
0eeb81a
[core] - added changelog entries for recent changes (#15902)
maorleger Jun 22, 2021
556da80
[ContainerRegistry] switch to use official TS code generator (#15777)
jeremymeng Jun 23, 2021
63bc1fd
Arm cosmosdb release (#15789)
colawwj Jun 23, 2021
b499bfb
[KeyVault] - Migrate Key Vault Admin package to Core V2 (#15881)
maorleger Jun 23, 2021
56c7442
Skip rush update when runnign using pull request (#15907)
praveenkuttappan Jun 23, 2021
5728f70
Move to @azure/msal-node-extensions 1.0.0-alpha.7 (#15908)
witemple-msft Jun 23, 2021
023db76
[Communication]Feature: add sender display name within send typing no…
LuChen-Microsoft Jun 23, 2021
a1f909d
Update ubuntu VM image (#15706)
chidozieononiwu Jun 23, 2021
6c59958
Default live test timeout to 60 minutes (#15926)
benbp Jun 23, 2021
137c671
Fix handling of typed arrays in request bodies (#15904)
xirzec Jun 23, 2021
65a90e5
[Tables] Migration Guide (#15857)
joheredi Jun 23, 2021
99d53b6
[core] - GA core-rest-pipeline 1.1.0 (#15923)
maorleger Jun 23, 2021
2d2c656
[Tables] Support AAD Authentication (#15852)
joheredi Jun 23, 2021
46078e3
Doc improvements for blob storage file upload content type 2 (#12938)
diberry Jun 24, 2021
58b1993
[service-bus] Fixing issue where links were not removed from our inte…
richardpark-msft Jun 24, 2021
bb833fc
arm-trafficmanager-release (#15695)
colawwj Jun 24, 2021
b77a2a4
arm-eventgrid-release (#15791)
colawwj Jun 24, 2021
93d102b
Bump up version for storage packages (#15849)
chidozieononiwu Jun 24, 2021
23bb270
[Core Rest] Add pagination helper for rest clients @azure-rest/core-c…
joheredi Jun 24, 2021
0b78ccf
CodeGen from PR 14830 in Azure/azure-rest-api-specs
Jun 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 10 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Rush provides many benefits:
- When a change is made in a local dependency, Rush will detect that the dependency is dirty and will rebuild it if you attempt to build a project that consumes that dependency.
- Rush runs project tasks in parallel, subject to the inter-project dependencies that it detects. It also performs incremental builds by default, not rebuilding anything unnecessary (unless you tell it to).

Not every library in the repository is managed by Rush yet, only those listed in the `projects` property in [rush.json](https://github.com/Azure/azure-sdk-for-js/blob/master/rush.json). Packages not managed by Rush can still be managed using `npm`.
Not every library in the repository is managed by Rush yet, only those listed in the `projects` property in [rush.json](https://github.com/Azure/azure-sdk-for-js/blob/main/rush.json). Packages not managed by Rush can still be managed using `npm`.

## Setting up your environment

Expand Down Expand Up @@ -91,7 +91,7 @@ To build packages managed by Rush:

To build packages not managed by Rush:

4. Navigate to the package directory as described in our [repository structure](https://github.com/Azure/azure-sdk/blob/master/docs/policies/repostructure.md)
4. Navigate to the package directory as described in our [repository structure](https://github.com/Azure/azure-sdk/blob/main/docs/policies/repostructure.md)
5. Install the package dependencies (`npm install`)
6. Build the package (`npm run build`)

Expand Down Expand Up @@ -134,7 +134,7 @@ By default, Rush only displays things written to `STDERR`. If you want to see th

If you want to run the tests of a specific project, go to that project's folder and execute `rushx test`. All of the tests will automatically run both in NodeJS and in the browser. To target these environments individually, you can run `rushx test:node` and `rushx test:browser`.

By default, these npm scripts run previously recorded tests. The recordings have been generated by using a custom recording library called [test-utils-recorder](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/test-utils/recorder/README.md). We will examine how to run recorded tests and live tests in the following sections.
By default, these npm scripts run previously recorded tests. The recordings have been generated by using a custom recording library called [test-utils-recorder](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/README.md). We will examine how to run recorded tests and live tests in the following sections.

#### Recorded tests

Expand All @@ -152,15 +152,15 @@ The readme file in the `test` folder of each package lists the Azure resources a

> Note: Our projects use dotenv to allow you to use `.env` files to set environment variables. Find the `sample.env` file nearest to the project you want to test to see a template of the expected `.env` file.

You can create the necessary Azure resources on your own, or automate this process by using the script called `New-TestResources.ps1` which uses ARM templates defined in a file named `test-resources.json` that exists in each project's folder. Follow the steps in [`Example 1 of New-TestResources.ps1`](https://github.com/Azure/azure-sdk-for-js/blob/master/eng/common/TestResources/New-TestResources.ps1.md#example-1) to set up a service principal and deploy the live test resources.
You can create the necessary Azure resources on your own, or automate this process by using the script called `New-TestResources.ps1` which uses ARM templates defined in a file named `test-resources.json` that exists in each project's folder. Follow the steps in [`Example 1 of New-TestResources.ps1`](https://github.com/Azure/azure-sdk-for-js/blob/main/eng/common/TestResources/New-TestResources.ps1.md#example-1) to set up a service principal and deploy the live test resources.

#### Regenerating recordings

If you modify the network calls (both the number of calls or their shape) either by changing the tests or source code of the project you're working on, the recordings will need to be re-generated.

Regenerating the recordings has the same requirements as running the live tests. You will be using the same `test` npm script with the environment variables pointing to previously created Azure resources. The only difference is that the `TEST_MODE` environment variable needs to be set to `record`. When this process finishes without errors, the recordings will be updated.

For more information the recorder, please visit the [test-utils-recorder's readme](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/test-utils/recorder/README.md).
For more information the recorder, please visit the [test-utils-recorder's readme](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/README.md).

### Other NPM scripts

Expand Down Expand Up @@ -239,20 +239,20 @@ We used to have a git hook that formats your changed files on commit but it was

### Enforcing Azure SDK design guidelines

Our libraries follow the [TypeScript SDK design guidelines](https://azure.github.io/azure-sdk/typescript_introduction.html) to enhance the productivity of developers connecting to Azure services. These guidelines are enforced by our custom [ESLint plugin](https://github.com/Azure/azure-sdk-for-js/tree/master/common/tools/eslint-plugin-azure-sdk). Follow these instruction to use the plugin:
Our libraries follow the [TypeScript SDK design guidelines](https://azure.github.io/azure-sdk/typescript_introduction.html) to enhance the productivity of developers connecting to Azure services. These guidelines are enforced by our custom [ESLint plugin](https://github.com/Azure/azure-sdk-for-js/tree/main/common/tools/eslint-plugin-azure-sdk). Follow these instruction to use the plugin:

- [add `eslint` to your `devDependencies`](https://github.com/Azure/azure-sdk-for-js/blob/8ec9801c17b175573a115fc8b2d6cbaeb17b0b09/sdk/template/template/package.json#L106)
- [add `eslint-plugin-azure-sdk` to your `devDependencies`](https://github.com/Azure/azure-sdk-for-js/blob/8ec9801c17b175573a115fc8b2d6cbaeb17b0b09/sdk/template/template/package.json#L93)
- add a linting npm script as follows:
- ["lint": "eslint package.json api-extractor.json src test --ext .ts"](https://github.com/Azure/azure-sdk-for-js/blob/8ec9801c17b175573a115fc8b2d6cbaeb17b0b09/sdk/template/template/package.json#L49)
- ["lint": "eslint package.json api-extractor.json src test --ext .ts"](https://github.com/Azure/azure-sdk-for-js/blob/8ec9801c17b175573a115fc8b2d6cbaeb17b0b09/sdk/template/template/package.json#L49)

You can run the plugin by excuting `rushx lint` inside your package directory.

If the package is internal, it should not follow the design guidelines and in turn should not be linted by the plugin. In this case, use the [internal configuration file](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/.eslintrc.internal.json) instead. For example: `"lint": "eslint --no-eslintrc -c ../../.eslintrc.internal.json package.json package.json src test --ext .ts"`

If the package is internal, it should not follow the design guidelines and in turn should not be linted by the plugin. In this case, use the [internal configuration file](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/.eslintrc.internal.json) instead. For example: `"lint": "eslint --no-eslintrc -c ../../.eslintrc.internal.json package.json package.json src test --ext .ts"`

## Onboarding a new library

All libraries must follow our [repository structure](https://github.com/Azure/azure-sdk/blob/master/docs/policies/repostructure.md) (specifically, it must be located at `sdk/<servicename>/<packagename>`) and your library's `package.json` must contain the required scripts as documented [above](#other-npm-scripts).
All libraries must follow our [repository structure](https://github.com/Azure/azure-sdk/blob/main/docs/policies/repostructure.md) (specifically, it must be located at `sdk/<servicename>/<packagename>`) and your library's `package.json` must contain the required scripts as documented [above](#other-npm-scripts).

The repository contains two different sets of libraries, each follows different rules for development and maintaining. The first type is generated automatically from the [swagger specifications](https://github.com/Azure/azure-rest-api-specs) and their code should not be edited by hand. Onboarding such library is just a matter of pushing its auto-generated directory to the right location in the repository.

Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ Libraries which enable you to provision specific resources. They are responsible
- For detailed documentation visit our [Azure SDK for JavaScript documentation](https://aka.ms/js-docs)
- File an issue via [GitHub Issues](https://github.com/Azure/azure-sdk-for-js/issues)
- Check [previous questions](https://stackoverflow.com/questions/tagged/azure-sdk-js) or ask new ones on StackOverflow using `azure-sdk-js` tag.
- Read our [Support documentation](https://github.com/Azure/azure-sdk-for-js/blob/master/SUPPORT.md).
- Read our [Support documentation](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md).

### Community

Try our [community resources](https://github.com/Azure/azure-sdk-for-js/blob/master/SUPPORT.md#community-resources).
Try our [community resources](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md#community-resources).

### Reporting security issues and security bugs

Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) <secure@microsoft.com>. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://www.microsoft.com/msrc/faqs-report-an-issue).

## Contributing

For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-js/blob/master/CONTRIBUTING.md).
For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-js/blob/main/CONTRIBUTING.md).

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit
https://cla.microsoft.com.
Expand Down
11 changes: 6 additions & 5 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,22 +56,23 @@
// ]
// Following is required to allow for backward compatibility with Event Processor Host Track 1
"@azure/event-hubs": ["^2.1.4"],
"@opentelemetry/api": ["^0.18.1"],
// Monitor-opentelemetry-exporter and monitor-query both depend on different versions of @opentelemetry and need to be updated
"@opentelemetry/api": ["^0.18.1", "0.21.0"],
// Monitor: Allow node 10 types until Timeout / Timer conflict is resolved in OpenTelemetry repo
// TODO: remove when released https://github.com/open-telemetry/opentelemetry-js/pull/1352
// eslint v7.15 needs node v10.12
"@types/node": ["^10.0.0", "^10.12.0"],
// @azure/test-utils-perfstress should depend on lowest version of @azure/core-http for maximum compatibility, allowing test
// projects to choose a higher version if desired.
"@azure/core-http": ["^1.0.0"],
// @azure/container-registry and perf test are using the beta version in the repo.
"@azure/core-rest-pipeline": ["1.1.0-beta.4"],
// @azure/event-processor-host is on a much lower major version
"@azure/ms-rest-nodeauth": ["^0.9.2"],
// Idenity is moving from v1 to v2. Moving all packages to v2 is going to take a bit of time, in the mean time we could use v2 on the perf-identity tests.
"@azure/identity": ["2.0.0-beta.3", "^1.1.0"],
"@azure/identity": ["^2.0.0-beta.4", "2.0.0-beta.3", "^1.1.0"],
// Issue #14771 tracks updating to these versions
"@microsoft/api-extractor": ["7.13.2"],
"prettier": ["2.2.1"]
"prettier": ["2.2.1"],
// @azure/cosmos was unable to upgrade due to test failures, Issue #15928 tracks making this upgrade
"@azure/core-rest-pipeline": ["^1.0.3"]
}
}
Loading