Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR track2_@azure/arm-orbital] add x-ms-enum for orbital #7010

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions sdk/orbital/arm-orbital/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
# Release History

## 1.0.0-beta.3 (2022-01-05)

**Features**

## 1.0.0-beta.3 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
- Added Type Alias CapabilityType
- Added Enum KnownCapabilityType

### Other Changes
**Breaking Changes**

- Operation AvailableGroundStations.listByCapability has a new signature
- Removed Enum KnownEnum6


## 1.0.0-beta.2 (2021-12-27)

The package of @azure/arm-orbital is using our next generation design principles since version 1.0.0-beta.2, which contains breaking changes.
Expand Down
2 changes: 1 addition & 1 deletion sdk/orbital/arm-orbital/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021 Microsoft
Copyright (c) 2022 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
6 changes: 3 additions & 3 deletions sdk/orbital/arm-orbital/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"commit": "c77c6c634dc3644d65d3e35df5d73a9c34d3c956",
"commit": "c283c9b2b8a07d21c7e96bb0f6b12f5ab6578001",
"readme": "specification/orbital/resource-manager/readme.md",
"autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/orbital/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20211217.1",
"autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/orbital/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20211130.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/typescript@6.0.0-alpha.16.20211217.1"
"use": "@autorest/typescript@6.0.0-alpha.16.20211130.1"
}
16 changes: 3 additions & 13 deletions sdk/orbital/arm-orbital/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
"author": "Microsoft Corporation",
"description": "A generated SDK for AzureOrbital.",
"version": "1.0.0-beta.3",
"engines": {
"node": ">=12.0.0"
},
"engines": { "node": ">=12.0.0" },
"dependencies": {
"@azure/core-lro": "^2.2.0",
"@azure/abort-controller": "^1.0.0",
Expand All @@ -16,13 +14,7 @@
"@azure/core-rest-pipeline": "^1.1.0",
"tslib": "^2.2.0"
},
"keywords": [
"node",
"azure",
"typescript",
"browser",
"isomorphic"
],
"keywords": ["node", "azure", "typescript", "browser", "isomorphic"],
"license": "MIT",
"main": "./dist/index.js",
"module": "./dist-esm/src/index.js",
Expand All @@ -49,9 +41,7 @@
"type": "git",
"url": "https://github.com/Azure/azure-sdk-for-js.git"
},
"bugs": {
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
},
"bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" },
"files": [
"dist/**/*.js",
"dist/**/*.js.map",
Expand Down

This file was deleted.

24 changes: 12 additions & 12 deletions sdk/orbital/arm-orbital/review/arm-orbital.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export interface AvailableGroundStationListResult {
// @public
export interface AvailableGroundStations {
get(groundStationName: string, options?: AvailableGroundStationsGetOptionalParams): Promise<AvailableGroundStationsGetResponse>;
listByCapability(capability: Enum6, options?: AvailableGroundStationsListByCapabilityOptionalParams): PagedAsyncIterableIterator<AvailableGroundStation>;
listByCapability(capability: CapabilityType, options?: AvailableGroundStationsListByCapabilityOptionalParams): PagedAsyncIterableIterator<AvailableGroundStation>;
}

// @public
Expand Down Expand Up @@ -117,6 +117,9 @@ export interface AzureOrbitalOptionalParams extends coreClient.ServiceClientOpti
// @public
export type Capability = string;

// @public
export type CapabilityType = string;

// @public
export interface CloudError {
error?: CloudErrorBody;
Expand Down Expand Up @@ -316,9 +319,6 @@ export interface EndPoint {
protocol: Protocol;
}

// @public
export type Enum6 = string;

// @public
export enum KnownActionType {
// (undocumented)
Expand All @@ -333,6 +333,14 @@ export enum KnownCapability {
EarthObservation = "EarthObservation"
}

// @public
export enum KnownCapabilityType {
// (undocumented)
Communication = "Communication",
// (undocumented)
EarthObservation = "EarthObservation"
}

// @public
export enum KnownCreatedByType {
// (undocumented)
Expand All @@ -353,14 +361,6 @@ export enum KnownDirection {
Uplink = "uplink"
}

// @public
export enum KnownEnum6 {
// (undocumented)
Communication = "Communication",
// (undocumented)
EarthObservation = "EarthObservation"
}

// @public
export enum KnownOrigin {
// (undocumented)
Expand Down
2 changes: 1 addition & 1 deletion sdk/orbital/arm-orbital/src/azureOrbital.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class AzureOrbital extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-orbital/1.0.0-beta.2`;
const packageDetails = `azsdk-js-arm-orbital/1.0.0-beta.3`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand Down
10 changes: 5 additions & 5 deletions sdk/orbital/arm-orbital/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -605,21 +605,21 @@ export enum KnownProtocol {
*/
export type Protocol = string;

/** Known values of {@link Enum6} that the service accepts. */
export enum KnownEnum6 {
/** Known values of {@link CapabilityType} that the service accepts. */
export enum KnownCapabilityType {
EarthObservation = "EarthObservation",
Communication = "Communication"
}

/**
* Defines values for Enum6. \
* {@link KnownEnum6} can be used interchangeably with Enum6,
* Defines values for CapabilityType. \
* {@link KnownCapabilityType} can be used interchangeably with CapabilityType,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **EarthObservation** \
* **Communication**
*/
export type Enum6 = string;
export type CapabilityType = string;

/** Known values of {@link Capability} that the service accepts. */
export enum KnownCapability {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import * as Parameters from "../models/parameters";
import { AzureOrbital } from "../azureOrbital";
import {
AvailableGroundStation,
Enum6,
CapabilityType,
AvailableGroundStationsListByCapabilityNextOptionalParams,
AvailableGroundStationsListByCapabilityOptionalParams,
AvailableGroundStationsListByCapabilityResponse,
Expand Down Expand Up @@ -42,7 +42,7 @@ export class AvailableGroundStationsImpl implements AvailableGroundStations {
* @param options The options parameters.
*/
public listByCapability(
capability: Enum6,
capability: CapabilityType,
options?: AvailableGroundStationsListByCapabilityOptionalParams
): PagedAsyncIterableIterator<AvailableGroundStation> {
const iter = this.listByCapabilityPagingAll(capability, options);
Expand All @@ -60,7 +60,7 @@ export class AvailableGroundStationsImpl implements AvailableGroundStations {
}

private async *listByCapabilityPagingPage(
capability: Enum6,
capability: CapabilityType,
options?: AvailableGroundStationsListByCapabilityOptionalParams
): AsyncIterableIterator<AvailableGroundStation[]> {
let result = await this._listByCapability(capability, options);
Expand All @@ -78,7 +78,7 @@ export class AvailableGroundStationsImpl implements AvailableGroundStations {
}

private async *listByCapabilityPagingAll(
capability: Enum6,
capability: CapabilityType,
options?: AvailableGroundStationsListByCapabilityOptionalParams
): AsyncIterableIterator<AvailableGroundStation> {
for await (const page of this.listByCapabilityPagingPage(
Expand All @@ -95,7 +95,7 @@ export class AvailableGroundStationsImpl implements AvailableGroundStations {
* @param options The options parameters.
*/
private _listByCapability(
capability: Enum6,
capability: CapabilityType,
options?: AvailableGroundStationsListByCapabilityOptionalParams
): Promise<AvailableGroundStationsListByCapabilityResponse> {
return this.client.sendOperationRequest(
Expand Down Expand Up @@ -126,7 +126,7 @@ export class AvailableGroundStationsImpl implements AvailableGroundStations {
* @param options The options parameters.
*/
private _listByCapabilityNext(
capability: Enum6,
capability: CapabilityType,
nextLink: string,
options?: AvailableGroundStationsListByCapabilityNextOptionalParams
): Promise<AvailableGroundStationsListByCapabilityNextResponse> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import { PagedAsyncIterableIterator } from "@azure/core-paging";
import {
AvailableGroundStation,
Enum6,
CapabilityType,
AvailableGroundStationsListByCapabilityOptionalParams,
AvailableGroundStationsGetOptionalParams,
AvailableGroundStationsGetResponse
Expand All @@ -24,7 +24,7 @@ export interface AvailableGroundStations {
* @param options The options parameters.
*/
listByCapability(
capability: Enum6,
capability: CapabilityType,
options?: AvailableGroundStationsListByCapabilityOptionalParams
): PagedAsyncIterableIterator<AvailableGroundStation>;
/**
Expand Down