Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-advisor] update readme.python.md #8164

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/advisor/arm-advisor/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021 Microsoft
Copyright (c) 2022 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion sdk/advisor/arm-advisor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ REST APIs for Azure Advisor

[Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/advisor/arm-advisor) |
[Package (NPM)](https://www.npmjs.com/package/@azure/arm-advisor) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-advisor) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-advisor?view=azure-node-preview) |
[Samples](https://github.com/Azure-Samples/azure-samples-js-management)

## Getting started
Expand Down
7 changes: 4 additions & 3 deletions sdk/advisor/arm-advisor/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"commit": "54ee1a9eb50c13e0790627749f986c886ad4f4db",
"commit": "fa7a4993aebfafce15bdc00b5af9a62ee64f20ab",
"readme": "specification/advisor/resource-manager/readme.md",
"autorest_command": "autorest --version=3.1.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20211217.1",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/advisor/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/typescript@6.0.0-alpha.16.20211217.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.1.2",
"use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
}
25 changes: 19 additions & 6 deletions sdk/advisor/arm-advisor/api-extractor.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"mainEntryPointFilePath": "./dist-esm/src/index.d.ts",
"docModel": { "enabled": true },
"apiReport": { "enabled": true, "reportFolder": "./review" },
"docModel": {
"enabled": true
},
"apiReport": {
"enabled": true,
"reportFolder": "./review"
},
"dtsRollup": {
"enabled": true,
"untrimmedFilePath": "",
"publicTrimmedFilePath": "./types/arm-advisor.d.ts"
},
"messages": {
"tsdocMessageReporting": { "default": { "logLevel": "none" } },
"tsdocMessageReporting": {
"default": {
"logLevel": "none"
}
},
"extractorMessageReporting": {
"ae-missing-release-tag": { "logLevel": "none" },
"ae-unresolved-link": { "logLevel": "none" }
"ae-missing-release-tag": {
"logLevel": "none"
},
"ae-unresolved-link": {
"logLevel": "none"
}
}
}
}
}
4 changes: 2 additions & 2 deletions sdk/advisor/arm-advisor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for AdvisorManagementClient.",
"version": "3.0.1",
"version": "1.0.0-beta.1",
"engines": {
"node": ">=12.0.0"
},
Expand Down Expand Up @@ -97,4 +97,4 @@
},
"sideEffects": false,
"autoPublish": true
}
}
2 changes: 1 addition & 1 deletion sdk/advisor/arm-advisor/src/advisorManagementClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class AdvisorManagementClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-advisor/3.0.0`;
const packageDetails = `azsdk-js-arm-advisor/1.0.0-beta.1`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand Down
8 changes: 1 addition & 7 deletions sdk/advisor/arm-advisor/test/sampleTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ import {
env,
record,
RecorderEnvironmentSetup,
Recorder,
isPlaybackMode,
delay
Recorder
} from "@azure-tools/test-recorder";
import * as assert from "assert";

Expand All @@ -33,10 +31,6 @@ const recorderEnvSetup: RecorderEnvironmentSetup = {
queryParametersToSkip: []
};

export const testPollingOptions = {
updateIntervalInMs: isPlaybackMode() ? 0 : undefined,
};

describe("My test", () => {
let recorder: Recorder;

Expand Down
16 changes: 12 additions & 4 deletions sdk/advisor/arm-advisor/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"lib": ["es6", "dom"],
"lib": [
"es6",
"dom"
],
"declaration": true,
"outDir": "./dist-esm",
"importHelpers": true
},
"include": ["./src/**/*.ts", "./test/**/*.ts"],
"exclude": ["node_modules"]
}
"include": [
"./src/**/*.ts",
"./test/**/*.ts"
],
"exclude": [
"node_modules"
]
}
7 changes: 4 additions & 3 deletions sdk/advisor/ci.mgmt.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.

trigger:
branches:
include:
Expand All @@ -10,6 +10,7 @@ trigger:
include:
- sdk/advisor/ci.mgmt.yml
- sdk/advisor/arm-advisor/
- sdk/advisor/arm-advisor
pr:
branches:
include:
Expand All @@ -23,11 +24,11 @@ pr:
include:
- sdk/advisor/ci.mgmt.yml
- sdk/advisor/arm-advisor/

- sdk/advisor/arm-advisor
extends:
template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: advisor
Artifacts:
- name: azure-arm-advisor
safeName: azurearmadvisor
safeName: azurearmadvisor