Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-compute] VMSS Flex Disk deleteOption changes #8334

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 23 additions & 8 deletions sdk/compute/arm-compute/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
# Release History

## 18.0.0 (2022-04-05)

**Features**

## 17.3.1 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed
- Added Interface DedicatedHostGroupPropertiesAdditionalCapabilities
- Interface VirtualMachineScaleSetDataDisk has a new optional parameter deleteOption
- Interface VirtualMachineScaleSetOSDisk has a new optional parameter deleteOption
- Type Alias DedicatedHostGroup has a new parameter additionalCapabilities
- Type Alias DedicatedHostGroupUpdate has a new parameter additionalCapabilities

### Other Changes
**Breaking Changes**

- Interface DiskUpdate no longer has parameter dataAccessAuthMode
- Interface SnapshotUpdate no longer has parameter dataAccessAuthMode
- Interface SupportedCapabilities no longer has parameter architecture
- Type Alias Disk no longer has parameter dataAccessAuthMode
- Type Alias GalleryImage no longer has parameter architecture
- Type Alias GalleryImageUpdate no longer has parameter architecture
- Type Alias Snapshot no longer has parameter dataAccessAuthMode
- Type Alias VirtualMachineImage no longer has parameter architecture
- Removed Enum KnownArchitecture
- Removed Enum KnownArchitectureTypes
- Removed Enum KnownDataAccessAuthMode


## 17.3.0 (2022-03-02)

**Features**
Expand Down
11 changes: 0 additions & 11 deletions sdk/compute/arm-compute/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Compute Client
- [LTS versions of Node.js](https://nodejs.org/about/releases/)
- Latest versions of Safari, Chrome, Edge and Firefox.

See our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.

### Prerequisites

- An [Azure subscription][azure_sub].
Expand Down Expand Up @@ -51,17 +49,8 @@ For more information about how to create an Azure AD Application check out [this
```javascript
const { ComputeManagementClient } = require("@azure/arm-compute");
const { DefaultAzureCredential } = require("@azure/identity");
// For client-side applications running in the browser, use InteractiveBrowserCredential instead of DefaultAzureCredential. See https://aka.ms/azsdk/js/identity/examples for more details.

const subscriptionId = "00000000-0000-0000-0000-000000000000";
const client = new ComputeManagementClient(new DefaultAzureCredential(), subscriptionId);

// For client-side applications running in the browser, use this code instead:
// const credential = new InteractiveBrowserCredential({
// tenantId: "<YOUR_TENANT_ID>",
// clientId: "<YOUR_CLIENT_ID>"
// });
// const client = new ComputeManagementClient(credential, subscriptionId);
```


Expand Down
7 changes: 4 additions & 3 deletions sdk/compute/arm-compute/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"commit": "4042a47cff72c950d35dd72149895b044ed79713",
"commit": "d749e7fe83b8d91653b0c49d38ca974a75f91270",
"readme": "specification/compute/resource-manager/readme.md",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\compute\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220225.1 --generate-sample=true",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/compute/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/typescript@6.0.0-alpha.16.20220225.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.2.3",
"use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
}
37 changes: 10 additions & 27 deletions sdk/compute/arm-compute/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for ComputeManagementClient.",
"version": "17.3.1",
"version": "18.0.0",
"engines": {
"node": ">=12.0.0"
},
Expand All @@ -29,21 +29,20 @@
"types": "./types/arm-compute.d.ts",
"devDependencies": {
"@microsoft/api-extractor": "^7.18.11",
"@rollup/plugin-commonjs": "^21.0.1",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-multi-entry": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^8.0.0",
"mkdirp": "^1.0.4",
"rollup": "^2.66.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"typescript": "~4.2.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
"@azure/identity": "^2.0.1",
"@azure-tools/test-recorder": "^1.0.0",
"mocha": "^7.1.1",
"cross-env": "^7.0.2",
"@azure/arm-network": "^26.0.0"
"cross-env": "^7.0.2"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/compute/arm-compute",
"repository": {
Expand Down Expand Up @@ -99,21 +98,5 @@
"docs": "echo skipped"
},
"sideEffects": false,
"//metadata": {
"constantPaths": [
{
"path": "src/computeManagementClient.ts",
"prefix": "packageDetails"
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-compute?view=azure-node-preview"
}
}
"autoPublish": true
}
48 changes: 9 additions & 39 deletions sdk/compute/arm-compute/review/arm-compute.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ export interface ApplicationProfile {
galleryApplications?: VMGalleryApplication[];
}

// @public
export type Architecture = string;

// @public
export type ArchitectureTypes = string;

// @public
export interface AutomaticOSUpgradePolicy {
disableAutomaticRollback?: boolean;
Expand Down Expand Up @@ -1126,9 +1120,6 @@ export interface CreationData {
uploadSizeBytes?: number;
}

// @public
export type DataAccessAuthMode = string;

// @public
export interface DataDisk {
caching?: CachingTypes;
Expand Down Expand Up @@ -1189,6 +1180,7 @@ export type DedicatedHostGroup = Resource & {
readonly hosts?: SubResourceReadOnly[];
readonly instanceView?: DedicatedHostGroupInstanceView;
supportAutomaticPlacement?: boolean;
additionalCapabilities?: DedicatedHostGroupPropertiesAdditionalCapabilities;
};

// @public (undocumented)
Expand All @@ -1202,6 +1194,11 @@ export interface DedicatedHostGroupListResult {
value: DedicatedHostGroup[];
}

// @public
export interface DedicatedHostGroupPropertiesAdditionalCapabilities {
ultraSSDEnabled?: boolean;
}

// @public
export interface DedicatedHostGroups {
createOrUpdate(resourceGroupName: string, hostGroupName: string, parameters: DedicatedHostGroup, options?: DedicatedHostGroupsCreateOrUpdateOptionalParams): Promise<DedicatedHostGroupsCreateOrUpdateResponse>;
Expand Down Expand Up @@ -1273,6 +1270,7 @@ export type DedicatedHostGroupUpdate = UpdateResource & {
readonly hosts?: SubResourceReadOnly[];
readonly instanceView?: DedicatedHostGroupInstanceView;
supportAutomaticPlacement?: boolean;
additionalCapabilities?: DedicatedHostGroupPropertiesAdditionalCapabilities;
};

// @public
Expand Down Expand Up @@ -1440,7 +1438,6 @@ export type Disk = Resource & {
securityProfile?: DiskSecurityProfile;
completionPercent?: number;
publicNetworkAccess?: PublicNetworkAccess;
dataAccessAuthMode?: DataAccessAuthMode;
};

// @public
Expand Down Expand Up @@ -1946,7 +1943,6 @@ export type DisksUpdateResponse = Disk;
// @public
export interface DiskUpdate {
burstingEnabled?: boolean;
dataAccessAuthMode?: DataAccessAuthMode;
diskAccessId?: string;
diskIopsReadOnly?: number;
diskIopsReadWrite?: number;
Expand Down Expand Up @@ -2356,7 +2352,6 @@ export type GalleryImage = Resource & {
purchasePlan?: ImagePurchasePlan;
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
features?: GalleryImageFeature[];
architecture?: Architecture;
};

// @public
Expand Down Expand Up @@ -2454,7 +2449,6 @@ export type GalleryImageUpdate = UpdateResourceDefinition & {
purchasePlan?: ImagePurchasePlan;
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
features?: GalleryImageFeature[];
architecture?: Architecture;
};

// @public
Expand Down Expand Up @@ -2865,22 +2859,6 @@ export enum KnownAggregatedReplicationState {
Unknown = "Unknown"
}

// @public
export enum KnownArchitecture {
// (undocumented)
Arm64 = "Arm64",
// (undocumented)
X64 = "x64"
}

// @public
export enum KnownArchitectureTypes {
// (undocumented)
Arm64 = "Arm64",
// (undocumented)
X64 = "x64"
}

// @public
export enum KnownAvailabilitySetSkuTypes {
// (undocumented)
Expand Down Expand Up @@ -2931,12 +2909,6 @@ export enum KnownConsistencyModeTypes {
FileSystemConsistent = "FileSystemConsistent"
}

// @public
export enum KnownDataAccessAuthMode {
AzureActiveDirectory = "AzureActiveDirectory",
None = "None"
}

// @public
export enum KnownDeleteOptions {
// (undocumented)
Expand Down Expand Up @@ -5304,7 +5276,6 @@ export type Snapshot = Resource & {
supportsHibernation?: boolean;
publicNetworkAccess?: PublicNetworkAccess;
completionPercent?: number;
dataAccessAuthMode?: DataAccessAuthMode;
};

// @public
Expand Down Expand Up @@ -5415,7 +5386,6 @@ export type SnapshotsUpdateResponse = Snapshot;

// @public
export interface SnapshotUpdate {
dataAccessAuthMode?: DataAccessAuthMode;
diskAccessId?: string;
diskSizeGB?: number;
encryption?: Encryption;
Expand Down Expand Up @@ -5592,7 +5562,6 @@ export type SubResourceWithColocationStatus = SubResource & {
// @public
export interface SupportedCapabilities {
acceleratedNetwork?: boolean;
architecture?: Architecture;
}

// @public
Expand Down Expand Up @@ -5999,7 +5968,6 @@ export type VirtualMachineImage = VirtualMachineImageResource & {
hyperVGeneration?: HyperVGenerationTypes;
disallowed?: DisallowedConfiguration;
features?: VirtualMachineImageFeature[];
architecture?: ArchitectureTypes;
};

// @public
Expand Down Expand Up @@ -6457,6 +6425,7 @@ export type VirtualMachineScaleSet = Resource & {
export interface VirtualMachineScaleSetDataDisk {
caching?: CachingTypes;
createOption: DiskCreateOptionTypes;
deleteOption?: DiskDeleteOptionTypes;
diskIopsReadWrite?: number;
diskMBpsReadWrite?: number;
diskSizeGB?: number;
Expand Down Expand Up @@ -6685,6 +6654,7 @@ export interface VirtualMachineScaleSetNetworkProfile {
export interface VirtualMachineScaleSetOSDisk {
caching?: CachingTypes;
createOption: DiskCreateOptionTypes;
deleteOption?: DiskDeleteOptionTypes;
diffDiskSettings?: DiffDiskSettings;
diskSizeGB?: number;
image?: VirtualHardDisk;
Expand Down
Loading