-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrderedIntervalList #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, insert
and append
functions have O(n) on-chain complexity. In practice it'll kick in only in case of long contiguous ranges of holes inside list.
I think it could be optimized by building a linked list using pointer machine over storage. It'll require quite heavy rewrite.
@k06a what do you think should we spend some time now optimizing it?
Arguments should not have underscore prefix anymore, see OpenZeppelin 2.0 notation. |
…research into sc/feature/orderedlist_41
b16195d
to
049d59a
Compare
resolve #41