Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderedIntervalList #45

Merged
merged 14 commits into from
Dec 2, 2018
Merged

OrderedIntervalList #45

merged 14 commits into from
Dec 2, 2018

Conversation

patsak
Copy link
Contributor

@patsak patsak commented Nov 21, 2018

resolve #41

@patsak patsak requested a review from k06a November 21, 2018 11:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+14.0%) to 62.651%

Totals Coverage Status
Change from base Build 152: 14.0%
Covered Lines: 75
Relevant Lines: 128

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 21, 2018

Pull Request Test Coverage Report for Build 185

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+26.5%) to 75.185%

Totals Coverage Status
Change from base Build 152: 26.5%
Covered Lines: 126
Relevant Lines: 178

💛 - Coveralls

Copy link

@Eenae Eenae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, insert and append functions have O(n) on-chain complexity. In practice it'll kick in only in case of long contiguous ranges of holes inside list.
I think it could be optimized by building a linked list using pointer machine over storage. It'll require quite heavy rewrite.
@k06a what do you think should we spend some time now optimizing it?

software/smartContract/contracts/OrderedIntervalList.sol Outdated Show resolved Hide resolved
software/smartContract/contracts/OrderedIntervalList.sol Outdated Show resolved Hide resolved
software/smartContract/contracts/OrderedIntervalList.sol Outdated Show resolved Hide resolved
@k06a
Copy link
Contributor

k06a commented Nov 21, 2018

Arguments should not have underscore prefix anymore, see OpenZeppelin 2.0 notation.

@k06a k06a merged commit ad845d9 into master Dec 2, 2018
@k06a k06a deleted the sc/feature/orderedlist_41 branch December 2, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solidity library OrderedLinkedList
4 participants