Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

fix: wording for stepaway texts on UI #181

Merged
merged 16 commits into from
Feb 7, 2023

Conversation

konradlang
Copy link
Contributor

No description provided.

@konradlang konradlang linked an issue Feb 3, 2023 that may be closed by this pull request
@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 11:20 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik changed the title 162 change in wording for texts on UI fix: wording for stepaway texts on UI Feb 3, 2023
@konradlang konradlang linked an issue Feb 3, 2023 that may be closed by this pull request
@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 11:57 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 7.54% // Head: 7.67% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (d0ba16c) compared to base (eabdef4).
Patch coverage: 56.41% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #181      +/-   ##
===========================================
+ Coverage      7.54%   7.67%   +0.12%     
- Complexity      336     343       +7     
===========================================
  Files           321     323       +2     
  Lines         14992   15027      +35     
  Branches        978     981       +3     
===========================================
+ Hits           1131    1153      +22     
- Misses        13818   13828      +10     
- Partials         43      46       +3     
Impacted Files Coverage Δ
...otiator/control/component/LifeCycleStatusBean.java 0.00% <0.00%> (ø)
...ifecycle/requeststatus/RequestStatusAbandoned.java 29.78% <0.00%> (ø)
...c/csit/service/negotiator/util/PropertiesUtil.java 46.66% <46.66%> (ø)
...vice/negotiator/lifecycle/util/StepAwayReason.java 93.75% <93.75%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 12:46 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 12:53 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 13:42 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik temporarily deployed to development February 3, 2023 15:04 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik temporarily deployed to development February 6, 2023 10:00 — with GitHub Actions Inactive
@RadovanTomik RadovanTomik merged commit 159865f into master Feb 7, 2023
@RadovanTomik RadovanTomik deleted the 162-change-in-wording-for-texts-on-ui branch February 7, 2023 17:59
RadovanTomik added a commit that referenced this pull request Mar 3, 2023
* Throttling the requests by waiting for x seconds in the range [0,3] before requesting the next batch.

* changed text for step away reasons  - #163 (#163)

* Change the wording for texts according to suggestions - #162 - (#162)

* feat: dynamic step away view

* feat: dynamic step away view

---------

Co-authored-by: Radovan Tomášik <tomasik@mail.muni.cz>
jungwire pushed a commit that referenced this pull request Mar 27, 2023
* Throttling the requests by waiting for x seconds in the range [0,3] before requesting the next batch.

* changed text for step away reasons  - #163 (#163)

* Change the wording for texts according to suggestions - #162 - (#162)

* feat: dynamic step away view

* feat: dynamic step away view

---------

Co-authored-by: Radovan Tomášik <tomasik@mail.muni.cz>
konradlang added a commit that referenced this pull request Mar 27, 2023
* should fix the problem with multirequest for locator and finder

* Hotfix: autologin from the directory (#170)

* added attempt to "login" without prompt if fails redirect to login page

* bugfix only overwrite redirect is no error is in QueryString

Co-authored-by: Emilian Jungwirth <emilian.jung+github@gmail.com>

* feature: acceptance test (#169)

* Documentation cleanup (#172)

* updated documentation

* Update development.md

* fix: not reachable collection status message (#173)

* Publishing to GitHub packages (#174)

* feat: GitHub packages

* fix: maven settings

* fix: pom version

* fix: docker registries

* feat: deploy workflow

* feat: deploy workflow on dispatch

* Fix: trivy image scan

* fix: trivy image scan

* fix: deployment url

* fix: jackson media to 2.35 (#175)

* fix: jackson media to 2.35

* fix: commons-configuration to 1.10

* fix: trivy scan

* fix: acceptance test

* Throttling the requests by waiting for x seconds in the range [0,3] before requesting the next batch. (#176)

* hotfix: not reachable typo

* Fix to add userID for selected queries; add queries for owners without queryID to allow acting on behalf of Biobank; (#179)

for details see RT #7426: AW: [ext] AW: Negotiator requests

* Update build.yml

* Update build.yml

* Update build.yml

* fix: wording for stepaway texts on UI (#181)

* Throttling the requests by waiting for x seconds in the range [0,3] before requesting the next batch.

* changed text for step away reasons  - #163 (#163)

* Change the wording for texts according to suggestions - #162 - (#162)

* feat: dynamic step away view

* feat: dynamic step away view

---------

Co-authored-by: Radovan Tomášik <tomasik@mail.muni.cz>

* feat: mail notifications toggle

Co-authored-by: Konrad Lang <110096044+konradlang@users.noreply.github.com>

* Feat: no basic auth (#183)

* feat: removed auth check

* feat: removed auth check
* fix: tests mocks

* feat: favicon and tag title (#184)

* feat: favicon and tag title

* feat: favicon and tag title for admin

* Revert "Feat: no basic auth (#183)" (#185)

This reverts commit 3546897.

* chore: new favicon

* chore: new favicon (#186)

* chore: new favicon

* chore: workflow hardening

* chore: production deployment workflow

* chore: production deployment workflow

* hotfix: surefire config

* fix: dockerhub credentials

* hotfix: maven settings (#189)

* hotfix: maven settings

* chore: workflow cleanup

* Hotfix/performace owner query load (#188)

* getQuery by ID for owner directly from DB

* redirect to researcher query detail page if not an owner

* only use query_paarm_for redirect

* fix: dockerhub credentials

* removed old commented code

* added check for query_param

---------

Co-authored-by: Emilian Jungwirth <emilian.jung+github@gmail.com>

* Feat/swagger (#187)

* feat: swagger json

* fix: git properties

* chore: workflow java version 11

* feat: swagger-ui

* Update pom.xml to 2.7.6

* update unit tests

---------

Co-authored-by: Radovan Tomášik <tomasik@mail.muni.cz>
Co-authored-by: Konrad Lang <110096044+konradlang@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change text for step away reasons Change in wording for texts on UI
3 participants