Release 0.9.0 #121
Merged
Release 0.9.0 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from 0.8.0
feat(xml_files): add PNSSet parser
GeorgeHernandez541
previously approved these changes
Mar 27, 2024
mscf
approved these changes
Apr 10, 2024
| <name>ECG</name> | ||
| <number>0</number> | ||
| <unit>uV</unit> | ||
| <psgType>0</psgType> |
There was a problem hiding this comment.
Do you know what psgType is supposed to represent?
There was a problem hiding this comment.
I'm not really sure. We should be able to define what this field means.
| <number>0</number> | ||
| <unit>uV</unit> | ||
| <psgType>0</psgType> | ||
| <mapping>1</mapping> |
There was a problem hiding this comment.
Does the number field represent the hardware channel number? What is mapping for?
There was a problem hiding this comment.
If I'm not wrong, the number field indicates the channel index that should be used to get samples from the signal file.
GeorgeHernandez541
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
pnsSet.xmlfilesFixed
FileInfoclass