Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add coordinates and sensor layout XML files for 10-20 layout #123

Merged
merged 8 commits into from
Jul 1, 2024
Merged

feat: add coordinates and sensor layout XML files for 10-20 layout #123

merged 8 commits into from
Jul 1, 2024

Conversation

damian5710
Copy link
Collaborator

No description provided.

@damian5710 damian5710 marked this pull request as ready for review June 6, 2024 21:43
damian5710
damian5710 commented Jun 7, 2024
View reviewed changes
mffpy/resources/coordinates/Standard 10-20 (19 ch).xml
@@ -0,0 +1,164 @@
<?xml version='1.0' encoding='UTF-8'?>
<coordinates xmlns="http://www.egi.com/coordinates_mff"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to http://www.bel.company/coordinates_mff?

mffpy/resources/coordinates/Standard 10-20 (19 ch).xml Outdated Show resolved Hide resolved
marianofco
marianofco requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@marianofco marianofco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong with some electrodes, at least with the Pz, P3, P4, P7, P8, and probably O1 and O2:
image

marianofco
marianofco requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@marianofco marianofco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coordinates are not symmetric, compared to for instance GSN256, but it shoulddn't be an issue right now:

image

(left: GSN 256 and right GHW 130)

  • Please modify the date time and acq mode as commented

@damian5710 damian5710 enabled auto-merge July 1, 2024 22:42
@damian5710 damian5710 disabled auto-merge July 1, 2024 22:43
@damian5710 damian5710 merged commit 4717c91 into develop Jul 1, 2024
1 check passed
@damian5710 damian5710 deleted the feature-10-20-support branch July 1, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jusjusjus jusjusjus jusjusjus left review comments

@marianofco marianofco marianofco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damian5710 @jusjusjus @marianofco