Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds celldemo_FindMaxima_makeSpots.groovy #56

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

romainGuiet
Copy link
Member

No description provided.

Copy link
Member

@NicoKiaru NicoKiaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, few one important thing at the end that I did not get... (see comment)

* B - create Imaris spots from the Results Table
*/

// start-up cleaning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning what ? (I guess the results table)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the roiManager , close all the images and make sure to be connected to Imaris

IJ.run("Close All", "");
EasyXT.Utils.connectToImaris()

// imports
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we put the imports at the end of the scripts (@lacan 's convention)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 17a9d97

IJ.run(c3_imp, "Median 3D...", "x=2 y=2 z=2");

// Use a simple FindMaxima per Slice
// (more adavaned tools can be used like RS-FISH (https://github.com/PreibischLab/RS-FISH#download , update site : "Radial Symmetry") )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: advanced

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 17a9d97

Comment on lines 68 to 71
radiusXYZ = new Point3D()
radiusXYZ.setX(xRad_spot as double )
radiusXYZ.setY(yRad_spot as double)
radiusXYZ.setZ(zRad_spot as double )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these lines necessary ? I don't get it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it more clear with d10eaff ?

return pt
}
// Finally create the ImarisSpots
spots = EasyXT.Spots.create(coordinates , radiusXYZ, 0)// single timepoint -> 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see d10eaff

@romainGuiet romainGuiet merged commit e066c0a into master Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants