Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding="utf8" to resolve UnicodeDecodeError: 'gbk' codec can't… #4

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

allenwoods
Copy link
Contributor

add encoding="utf8" in open function, otherwise using Chinese and other language will lead to UnicodeDecodeError

@BMPixel
Copy link
Owner

BMPixel commented Aug 20, 2024

Thank you so much for your kind help! The test seems to be failed. Can you please check it again? Or can you pass the test in your dev environment?

@BMPixel BMPixel merged commit c9aa218 into BMPixel:main Aug 21, 2024
1 check failed
@allenwoods
Copy link
Contributor Author

allenwoods commented Sep 5, 2024

Sorry for the late response. There are indeed some tests, but they exist before I make any change, so I suppose they should be fixed by another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants