Change order of logged register/email sent events

BNETDocs · Aug 23, 2019 · 8f541cb · 8f541cb
1 parent 20a55fe
commit 8f541cb
Showing 1 changed file with 19 additions and 20 deletions.
diff --git a/src/controllers/User/Register.php b/src/controllers/User/Register.php
@@ -172,7 +172,25 @@ protected function tryRegister(Router &$router, UserRegisterModel &$model) {
 
     }
 
-    if ($success) {
+    if (!$success) {
+      $model->error = 'INTERNAL_ERROR';
+    } else {
+      $model->error = false;
+
+      Logger::logEvent(
+        EventTypes::USER_CREATED,
+        $user_id,
+        getenv("REMOTE_ADDR"),
+        json_encode([
+          "error"           => $model->error,
+          "requirements"    => $req,
+          "email"           => $email,
+          "username"        => $username,
+          "display_name"    => null,
+          "options_bitmask" => 0,
+        ])
+      );
+
       $state = new StdClass();
 
       $mail = new PHPMailer( true ); // true enables exceptions
@@ -239,25 +257,6 @@ protected function tryRegister(Router &$router, UserRegisterModel &$model) {
         $model->error = "EMAIL_FAILURE";
       }
     }
-
-    if (!$success) {
-      $model->error = "INTERNAL_ERROR";
-    } else {
-      $model->error = false;
-    }
-    Logger::logEvent(
-      EventTypes::USER_CREATED,
-      $user_id,
-      getenv("REMOTE_ADDR"),
-      json_encode([
-        "error"           => $model->error,
-        "requirements"    => $req,
-        "email"           => $email,
-        "username"        => $username,
-        "display_name"    => null,
-        "options_bitmask" => 0,
-      ])
-    );
   }
 
 }