Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to C++11 #4128

Closed
wants to merge 1 commit into from
Closed

Switch to C++11 #4128

wants to merge 1 commit into from

Conversation

Flowdalic
Copy link
Contributor

This PR is, for now, primary to check if travis would fail with C++11 and as basis for discussion. Related to #4126 (comment).

@AenBleidd AenBleidd marked this pull request as draft December 16, 2020 19:02
@AenBleidd
Copy link
Member

Travis CI will not fail, but AppVeyor will

@AenBleidd
Copy link
Member

And I'm afraid, you'll have to wait ~2 hours because currently Travis CI is not usable because of their new policies

@Flowdalic
Copy link
Contributor Author

Travis CI will not fail, but AppVeyor will

FYI AppVeyor did not fail. Not sure what to make of it, hoping that it could mean that BOINC could easily switch to C++11, but I somehow expect that you will teach me better. :)

@AenBleidd
Copy link
Member

FYI AppVeyor did not fail

Because you changed only build instructions for linux. But if you include any C++11 instruction - AppVeyor will fail because Visual Studio 2010 has not C++11 support

@talregev
Copy link
Contributor

Why we still support vs2010?

@AenBleidd
Copy link
Member

@talregev because this will not be true soon 😜

@talregev
Copy link
Contributor

@AenBleidd That is great news! :)

@AenBleidd
Copy link
Member

This is not needed anymore

@AenBleidd AenBleidd closed this Jan 11, 2021
@Flowdalic Flowdalic deleted the c++11 branch January 11, 2021 19:34
@Flowdalic
Copy link
Contributor Author

Great. \o/

With which commit did the upgrade to a new C++ standard version happen?

@AenBleidd
Copy link
Member

This decision was made offline and no commit was required. But if you need some as a start point, then it could be this one: 180ea88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants