client: fix overly aggressive project-wide file transfer backoff policy. #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old: if we get more than 3 upload or download failures for a project, do a backoff for each failure. Problem: if we start a bunch of transfers (say the N output files of a job) and they all fail, we back off for too long, e.g.: try N uploads back off 2^N minutes try N uploads back off 4^N minutes ... New: on a failure, ignore it if we're already backed off. So the behavior should be something like: try N uploads back off 1 minute try N uploads back off 2 minutes ...
|
Should also fix #3778 |
AenBleidd
approved these changes
Nov 9, 2021
|
Code itself looks fine, but I haven't tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old: if we get more than 3 upload or download failures for a project,
do a backoff for each failure.
Problem: if we start a bunch of transfers (say the N output files of a job)
and they all fail, we back off for too long, e.g.:
try N uploads
back off 2^N minutes
try N uploads
back off 4^N minutes
...
New: on a failure, ignore it if we're already backed off.
So the behavior should be something like:
try N uploads
back off 1 minute
try N uploads
back off 2 minutes
...
Should fix #4572