-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for building Windows installers #5355
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing registry key, fix CAVerifyInstallDirectories components
…rent selection of default screensaver with disabled feature, changed flow of dialogs
@AenBleidd please review and send feedback. |
@parvit You should fix your conflicts. |
This was already discussed is a separate chat |
Will reopen from different branch |
AenBleidd
added
OS: Windows
C: Installer
and removed
PR: Review required
C: Installer - Windows
labels
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5065, please review and send feedback.
Description of the Change
The change implements a new workflow that allows to build the installers for windows platform using the WiX toolset version 3.14.
Versions
Installers will be generated (supporting Windows 7 platform onward) for the following combinations:
Prerequisites to build
The following software must be available in order to build locally:
Secrets
Two Github secrets are necessary for correct operation of workflow:
CERTIFICATE_FILE
secretOutput
The generated installers have the nomenclature
boinc_{version}_windows_{variant}.exe
, where:BOINC_VERSION_STRING
extracted from fileversion.h
when on CI, if building locally it is the value passed toinstaller.ps1
x86_64
,x86_64_vbox
,arm64
)An example name for x64 version 7.24.0.0 would be:
boinc_7.24.0.0_windows_x86_64.exe
.Building and Integration
Workflow can be triggered by pushing on
master
branch.Locally, the 'build' and 'build/prerequisistes' folders must be created, their contents being:
build
: the contents of 'manager' and 'client' packages, required binaries (boinc.exe, boincmgr.exe, etc...) are checked for presence and additional files harvested and included in installationprerequisites
: if required by the variant (eg. x64+VirtualBox) the fileVirtualBox-7.0.10-158379-Win.exe
(https://download.virtualbox.org/virtualbox/7.0.10/VirtualBox-7.0.10-158379-Win.exe) is expected, empty otherwiseNow the powershell script
installer.ps1
can be invoked like so:pwsh -f .\installer.ps1 -Version <version> -Type <type> -Certificate <pfx path> -CertificatePass <pfx password>
With 'type' being one of:
x64
,x64_vbox
,arm64
.After finishing execution the result can be found in
build/
directory.Release Notes
Building Windows installers with WiX toolkit