Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPV proof option for Anchors. Differentiate anchors, extra-tx witnesses and tx witnesses. #83

Closed
wants to merge 6 commits into from

Conversation

dr-orlovsky
Copy link
Member

Implements RGB-WG/RFC#3 at the level of BP Core.

This would allow to validate single-use seals without Internet connectivity and bitcoin blockchain indexer.

@dr-orlovsky dr-orlovsky added *consensus* Issues affecting distributed concensus *scalability* Issues affecting system scalability epic Epic task refactoring Refactoring of the existing code labels Mar 30, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 30, 2024
@dr-orlovsky dr-orlovsky self-assigned this Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 17.14286% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 47.4%. Comparing base (7b1ff00) to head (7aece00).

❗ Current head 7aece00 differs from pull request most recent head 5b93351. Consider uploading reports for the commit 5b93351 to get more accurate results

Files Patch % Lines
dbc/src/anchor.rs 0.0% 22 Missing ⚠️
consensus/src/block.rs 0.0% 4 Missing ⚠️
seals/src/txout/witness.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #83     +/-   ##
========================================
- Coverage    48.2%   47.4%   -0.9%     
========================================
  Files          36      34      -2     
  Lines        3290    3174    -116     
========================================
- Hits         1587    1503     -84     
+ Misses       1703    1671     -32     
Flag Coverage Δ
rust 47.4% <17.1%> (-0.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member Author

Closing since it was decided that SPV proofs are not a consensus-level thing and must be added only in the standard library.

@dr-orlovsky dr-orlovsky closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Issues affecting distributed concensus epic Epic task refactoring Refactoring of the existing code *scalability* Issues affecting system scalability
Projects
Development

Successfully merging this pull request may close these issues.

1 participant