Merge pull request #2 from onuyanik/feature/balance-query-upgrade

Implemented new "account balance query by denom" endpoint
BTCTrader · Apr 12, 2022 · c94b910 · c94b910
2 parents f37f682 + d444bde
commit c94b910
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/CosmosSharp/CosmosSharp.csproj b/CosmosSharp/CosmosSharp.csproj
@@ -11,7 +11,7 @@
 		<Copyright>Copyright (c) 2021 BTCTrader</Copyright>
 		<PackageId>BTCTrader.CosmosSharp</PackageId>
 		<Product>BTCTrader.CosmosSharp</Product>
-		<Version>1.1.1</Version>
+		<Version>1.1.2</Version>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/CosmosSharp/StargateApi.cs b/CosmosSharp/StargateApi.cs
@@ -33,11 +33,32 @@ public async Task<AccountModel> GetAccount(string accountName, CancellationToken
             return await _httpHandler.GetJsonAsync<AccountModel>(url, _config.HeaderKeyValues, cancellationToken);
         }
 
-        public async Task<BalanceResponse> GetAccountBalance(string accountName, string denom, CancellationToken cancellationToken)
+        /// <summary>
+        /// Receives account balance via cosmos-sdk <b>before v0.44.4</b>. See more details about change in <a href="https://github.com/cosmos/cosmos-sdk/pull/10394#discussion_r734448254"><i>query account balance endpoint fix</i></a> and <a href="https://github.com/cosmos/cosmos-sdk/releases/tag/v0.44.4"><i>release notes</i></a>.
+        /// </summary>
+        /// <param name="accountName">address</param>
+        /// <param name="denom">denom or IBC denom</param>
+        /// <param name="cancellationToken"></param>
+        /// <returns></returns>
+        public async Task<BalanceResponse> GetAccountBalanceLegacy(string accountName, string denom, CancellationToken cancellationToken)
         {
             var url = $"{_config.HttpEndpoint}/cosmos/bank/v1beta1/balances/{accountName}/{denom}";
             return await _httpHandler.GetJsonAsync<BalanceResponse>(url, _config.HeaderKeyValues, cancellationToken);
         }
+
+        /// <summary>
+        /// Receives account balance via cosmos-sdk <b>as from v0.44.4</b>. See more details about <a href="https://github.com/cosmos/cosmos-sdk/pull/10394#discussion_r734448254"><i>query account balance endpoint fix</i></a> and <a href="https://github.com/cosmos/cosmos-sdk/releases/tag/v0.44.4"><i>release notes</i></a>.
+        /// </summary>
+        /// <param name="accountName">address</param>
+        /// <param name="denom">denom or IBC denom</param>
+        /// <param name="cancellationToken"></param>
+        /// <returns></returns>
+        public async Task<BalanceResponse> GetAccountBalance(string accountName, string denom, CancellationToken cancellationToken)
+        {
+            // grpc-gateway query account balance by IBC denom had an incorrect endpoint
+            var url = $"{_config.HttpEndpoint}/cosmos/bank/v1beta1/balances/{accountName}/by_denom?denom={denom}";
+            return await _httpHandler.GetJsonAsync<BalanceResponse>(url, _config.HeaderKeyValues, cancellationToken);
+        }
 
         public async Task<BlockInfo> GetLatestBlock(CancellationToken cancellationToken)
         {