Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing cmake scripts to make it compile #1586

Closed
wants to merge 1 commit into from

Conversation

Nerei
Copy link

@Nerei Nerei commented Dec 17, 2014

This code patch fixes forgotten include_directories(${PROTOBUF_INCLUDE_DIR})

@Nerei
Copy link
Author

Nerei commented Dec 17, 2014

Having much experience with OpenCV cmake scripts, I would do more development/refactoring of Caffe's scripts make them more featured, clever and smaller (in lines of code), but keep current behavior unchanged. But I don't know If authors of Caffe cmake are ok with such rework. I want also add CaffeConfig.cmake file generation so that users who use CMake can easily do find_package(Caffe).

@shelhamer
Copy link
Member

Improvements to the CMake build are welcome. The core developers are
responsible for the Makefile build, but the CMake build is currently
developed by the community until it is full featured so please do improve
it.
On Wed, Dec 17, 2014 at 01:51 Anatoly Baksheev notifications@github.com
wrote:

Having much experience with OpenCV cmake scripts, I would do more
development/refactoring of Caffe's scripts make them more featured, clever
and smaller (in lines of code), but keep current behavior unchanged. But I
don't know If authors of Caffe cmake are ok with such rework. I want also
add CaffeConfig.cmake file generation so that users who use CMake can
easily do find_package(Caffe).


Reply to this email directly or view it on GitHub
#1586 (comment).

@Nerei
Copy link
Author

Nerei commented Dec 20, 2014

Okay! Please please expect a big present after The New Year :-)

@Nerei Nerei mentioned this pull request Jan 2, 2015
@Nerei Nerei closed this Jan 2, 2015
@Nerei Nerei deleted the feature/cmake_compilation_fix branch May 15, 2015 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants