Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make lint' in OSX #176

Merged
merged 1 commit into from
Feb 27, 2014
Merged

Fix 'make lint' in OSX #176

merged 1 commit into from
Feb 27, 2014

Conversation

jeffdonahue
Copy link
Contributor

Thanks to @sguada for reporting in the comment thread on #132:

Seems that NONGEN_CXX_SRCS (Makefile variable intended to list all the files we want to include in lint) was empty in OSX due to some disagreement in the regex formatting of 'find'...give up on that and use an ugly but (hopefully?) reliable chain of -name ... -or -name ...

seems that NONGEN_CXX_SRCS wasn't getting populated in OSX due to some
disagreement in the regex formatting in find...give up on that and use
an ugly but reliable chain of -name ... -or -name ...
@shelhamer
Copy link
Member

Good find @sguada and thanks for the fix @jeffdonahue.

shelhamer added a commit that referenced this pull request Feb 27, 2014
@shelhamer shelhamer merged commit 6d8acab into BVLC:dev Feb 27, 2014
@sguada
Copy link
Contributor

sguada commented Feb 27, 2014

Thanks @jeffdonahue now it works in OSX but now it detects some problems in several files currently in dev

src/caffe/layers/bnll_layer.cpp:5:  Found C++ system header after other header. Should be: bnll_layer.h, c system, c++ system, other.  [build/include_order] [4]
src/caffe/layers/bnll_layer.cpp:29:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
src/caffe/layers/dropout_layer.cpp:45:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
src/caffe/layers/relu_layer.cpp:5:  Found C++ system header after other header. Should be: relu_layer.h, c system, c++ system, other.  [build/include_order] [4]
src/caffe/layers/relu_layer.cpp:25:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
src/caffe/layers/sigmoid_layer.cpp:5:  Found C++ system header after other header. Should be: sigmoid_layer.h, c system, c++ system, other.  [build/include_order] [4]
src/caffe/layers/sigmoid_layer.cpp:6:  Found C++ system header after other header. Should be: sigmoid_layer.h, c system, c++ system, other.  [build/include_order] [4]
src/caffe/layers/sigmoid_layer.cpp:29:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
src/caffe/layers/softmax_layer.cpp:41:  Add #include <algorithm> for max  [build/include_what_you_use] [4]
src/caffe/layers/softmax_layer.cpp:61:  Add #include <vector> for vector<>  [build/include_what_you_use] [4]
src/caffe/layers/softmax_loss_layer.cpp:48:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

I will not try to fix those in my PR otherwise they will get mixed

@jeffdonahue jeffdonahue deleted the osx-make-lint-fix branch March 10, 2014 01:29
mitmul pushed a commit to mitmul/caffe that referenced this pull request Sep 30, 2014
lukeyeager pushed a commit to lukeyeager/caffe that referenced this pull request Jun 27, 2016
Hotfix resolving meminfo divergence corner case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants