force_encoded_color flag and warning against mixed color-gray encoded DBs #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| cv_img = DecodeDatumToCVMatNative(datum); | ||
| if (cv_img.channels() != this->transformed_data_.channels()) | ||
| LOG(WARNING) << "You dataset contains encoded images with mixed " |
There was a problem hiding this comment.
s/you/your/
otherwise, this looks good to me
|
@philkr thanks for working on the fix. Please remember to squash and rebase for a clean merge. |
…g if images of different channel dimensions are encoded together
shelhamer
added a commit
to shelhamer/caffe
that referenced
this pull request
Feb 20, 2015
add force_encoded_color flag to the data layer and warn about mixed encoding
|
Just started trying to use encoded dbs again, and after re-creating a new encoded database with the latest caffe-dev (which I see is now deprecated) the problem persists - so this doesn't seem to be a problem restricted to older databases.. even newly created DBs need the flag to force it. Would advise testing this on a dataset with mixed image encodings - I'm using the original imagenet images (without them being re-encoded) and finding this. |
|
You are right. I was trying to be a bit too smart about it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1901, where older encoded DBs are not compatible with PR #1878. It adds a force_encoded_color flag to data_param, to force mixed encoded DBs to be read properly (as all color DBs).
It also warns users against the use of mixed color-gray DBs.