Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util functions converting formats between HDF5 and Blob #220

Closed
wants to merge 4 commits into from
Closed

Util functions converting formats between HDF5 and Blob #220

wants to merge 4 commits into from

Conversation

kloudkl
Copy link
Contributor

@kloudkl kloudkl commented Mar 17, 2014

To use the HDF5DataLayer to provide advanced data set and to enable input from various data sources, there should be functions converting Blob from and to other formats.

HDF5 is a very popular data set format in the scientific computing community. Building the bridge between it and Blob will open a lot of new opportunities to solve #126 and many complex practical problems.

@sergeyk
Copy link
Contributor

sergeyk commented Mar 17, 2014

@kloudkl I don't have time to review this right now, but could you quickly take a look at the latest commit to #203 (the HDF5 IO methods now load directly into Blob object)?

@kloudkl
Copy link
Contributor Author

kloudkl commented Mar 17, 2014

The direct purpose of this PR is to convert the features extracted by #161 into HDF5 for loading back conveniently later. The dims are assumed to be four but can be relaxed easily.

@sergeyk, your #203 combined with @tdomhan's #217 provided similar IO utilties and a customized data layer. I should have a look at whether there have been similar efforts before coding.

It is the first time here that multiple people worked on so closely related issues almost at the same time. Please continue to refine your PR.

@kloudkl
Copy link
Contributor Author

kloudkl commented Mar 17, 2014

If #203 does not intend to save Blobs into the HDF5 format files, then this PR still has something useful.

@sergeyk
Copy link
Contributor

sergeyk commented Mar 17, 2014

@kloudkl I will finish up my PR and @sguada will merge it into dev.

This PR is still valuable, because writing out to HDF5 is on our todo list: #213.

My main concern is adding the dependency on the HDF5 C++ interface. I see that it facilitates copying data. On the other hand, I think the solution in #203 does a fine job with only the C interface.

Pinging @sguada on this one. I think that the C++ interface will eventually be useful to us, for example for reading chunks at a time.

For now, my instinct is to leave this PR dormant, and ask @kloudkl to submit a PR for #213, and to only use the C interface if possible. if @kloudkl finds that #213 is made significantly easier/cleaner by the C++ interface, then I would be for including it as part of the Caffe source code to make compilation easier.

@kloudkl
Copy link
Contributor Author

kloudkl commented Mar 23, 2014

Update: #213 has been resolved in #252.

@sergeyk
Copy link
Contributor

sergeyk commented Mar 24, 2014

@kloudkl shall we close this PR?

@kloudkl kloudkl closed this Mar 25, 2014
lukeyeager pushed a commit to lukeyeager/caffe that referenced this pull request Aug 29, 2016
Fix for broken DataLayerTest/2.TestReshapeLevelDB test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants