Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_sample_data.py #2274

Merged
merged 2 commits into from
May 15, 2015
Merged

Update generate_sample_data.py #2274

merged 2 commits into from
May 15, 2015

Conversation

Ashwani001
Copy link
Contributor

Changed os.path.dirname(file) as it was returning empty...

Changed os.path.dirname(__file__) as it was returning empty...
@jeffdonahue
Copy link
Contributor

I think it's meant to be run from the Caffe root in which case the dirname result should not be empty. But making it runnable from anywhere seems fine. Maybe declare it at the top with a name like script_dir = os.path.dirname(os.path.abspath(__file__) to make the code clearer and more concise though?

made code more clearer and more concise
@Ashwani001
Copy link
Contributor Author

That could be the reason. I probably ran it from elsewhere. Changed it to what you suggested. Does look better.

@jeffdonahue
Copy link
Contributor

Thanks! Please squash to a single commit for merge.

@jeffdonahue
Copy link
Contributor

Never mind -- just noticed that they each had specific and clean commit messages so I'll go ahead and merge. Thanks @Ashwani001!

jeffdonahue added a commit that referenced this pull request May 15, 2015
Update generate_sample_data.py
@jeffdonahue jeffdonahue merged commit e20498e into BVLC:master May 15, 2015
@Ashwani001
Copy link
Contributor Author

Thanks @jeffdonahue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants