Fix memory leak in convert_mnist_siamese_data. #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a memory leak by using delete[] rather than plain delete.
|
Like #3011, I'm not sure why Travis isn't running here... given that this is a one-line change and looks right, I'll merge. Thanks for the fix @darrengarvey. |
jeffdonahue
added a commit
that referenced
this pull request
Sep 2, 2015
Fix memory leak in convert_mnist_siamese_data.
|
Thanks @jeffdonahue. I'm not sure either why Travis isn't running, as it ran for one or two of the PRs today (status looks OK: https://www.traviscistatus.com/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak by using delete[] rather than plain delete.