Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trivial slice/concat #3014

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Conversation

jeffdonahue
Copy link
Contributor

I'm pulling this out from #2033 for separate review. This allows trivial (identity) operation of the slice & concat layers by changing their MinTopBlobs or MinBottomBlobs (respectively) from 2 to 1. For performance, it is special cased to use ShareData and ShareDiff in this case, as done for other operations that correspond to the identity when the input & output Blobs are viewed as a flat data array (e.g. Reshape and Flatten).

This is used in #2033 to allow single-timestep operation of recurrent layers without an annoying special case.

@ronghanghu you recently commented that this would make your work easier as well -- maybe you could review this?

@ronghanghu ronghanghu added the RH label Sep 3, 2015
@ronghanghu
Copy link
Member

LGTM :) I'll take a closer look tomorrow.

@longjon
Copy link
Contributor

longjon commented Sep 3, 2015

Looks good to me. This is the correct behavior IMO.

@ronghanghu
Copy link
Member

Took another pass today and looks ready to merge. Thanks @jeffdonahue

ronghanghu added a commit that referenced this pull request Sep 3, 2015
@ronghanghu ronghanghu merged commit 66823b5 into BVLC:master Sep 3, 2015
@jeffdonahue jeffdonahue deleted the trivial-slice-concat branch September 3, 2015 22:20
myfavouritekk added a commit to myfavouritekk/caffe that referenced this pull request Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants