replace snprintf with a C++98 equivalent #3361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snprintf
is not consistently available on Windows.Although patchy support is possible (search snprintf in suggested reference), I find that
snprintf
may be advantageously replaced by a solution which doesn't involve defining arbitrarily sized buffers and converting between C and C++ strings.As I understand that C++ streams are not very popular and the main use of
snprintf
in Caffe is producing numbered batches, I suggest the introduction of a utility function (format_int
).