Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CuDNNConvolutionLayer for cuDNN v4 #3439

Merged
merged 1 commit into from
Dec 12, 2015
Merged

Conversation

flx42
Copy link
Contributor

@flx42 flx42 commented Dec 10, 2015

Add a macro to check the current cuDNN version

@flx42
Copy link
Contributor Author

flx42 commented Dec 10, 2015

The CMake website is under maintenance, causing the automated cmake builds to fail.
EDIT: it works now. The automated builds all passed.
ping @shelhamer for review, it should be a quick one.

Add a macro to check the current cuDNN version
@shelhamer
Copy link
Member

@flx42 will there be further ifdef guards for v4? If not this is simple and done. I'm happy to keep v3 compatibility and add v4 if it doesn't obscure the code. So far we have followed the current cuDNN version and dropped old versions (because of API changes).

Thanks for the PR.

@thatguymike
Copy link
Contributor

This is the only change until we get to more feature support like batch normalization. We should generally support the macro to better deal with API change-overs.

@flx42
Copy link
Contributor Author

flx42 commented Dec 11, 2015

For v3 and v4 only, I believe you could simply replace cudnnAddTensor by cudnnAddTensor_v3. But this function is also marked as deprecated so it seems less future-proof.

@shelhamer
Copy link
Member

Ok, agreed on the macro and this is fine as-is.

shelhamer added a commit that referenced this pull request Dec 12, 2015
Add ifdef in CuDNNConvolutionLayer for cuDNN v4
@shelhamer shelhamer merged commit 7953918 into BVLC:master Dec 12, 2015
shelhamer added a commit to shelhamer/caffe that referenced this pull request Apr 14, 2016
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
xygorn pushed a commit to xygorn/caffe that referenced this pull request Jul 8, 2016
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
fxbit pushed a commit to Yodigram/caffe that referenced this pull request Sep 1, 2016
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
zouxiaochuan pushed a commit to zouxiaochuan/caffe that referenced this pull request Oct 24, 2016
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
zouxiaochuan pushed a commit to zouxiaochuan/caffe that referenced this pull request Oct 24, 2016
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
zouxiaochuan pushed a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
zouxiaochuan pushed a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
zouxiaochuan pushed a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
acmiyaguchi pushed a commit to acmiyaguchi/caffe that referenced this pull request Nov 13, 2017
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR BVLC#3439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants