Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/BVLC/caffe/issues/4046 #4047

Closed
wants to merge 1 commit into from

Conversation

kleinric
Copy link

@kleinric kleinric commented Apr 26, 2016

Allows compilation on Ubuntu 16.04 using CMake and CUDA. Fixes #4046

@kleinric
Copy link
Author

This could possibly be fine-tuned to only apply the -D_FORCE_INLINES flags for the specific files that need it, rather than the entire repo. But I'm not sure where these changes may need to go.

@lukeyeager
Copy link
Contributor

Protip: use the phrase "Fixes #4046" in your commit message instead of "Fixes #4046" if you want to close the other bug automatically.

Or put it in the body of the first post in this PR. That's how I prefer to do it.

@kleinric
Copy link
Author

kleinric commented Apr 26, 2016

Thanks, I actually copied the entire github url in the commit message. Github
seems to have parsed it out itself. This is the first time I've done a pull
request, so not really sure how it all works yet :P

@lukeyeager
Copy link
Contributor

https://help.github.com/articles/closing-issues-via-commit-messages
https://github.com/blog/1506-closing-issues-via-pull-requests

Example: #3731

@shelhamer
Copy link
Member

Thanks for submitting a fix, but this was addressed upstream by CUDA 8 as concluded in #4046.

@shelhamer shelhamer closed this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants