Correctly apply padding to pooling layers when upgrading from V0 #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ross. I wasn't upgrading pooling layers when I wrote that because at the time the PoolingLayer didn't support padding. Will merge when Travis passes. |
|
Makes sense. Thanks! On Tue, Jul 22, 2014 at 1:04 PM, Jeff Donahue notifications@github.com
|
jeffdonahue
added a commit
that referenced
this pull request
Jul 22, 2014
Correctly apply padding to pooling layers when upgrading from V0
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Correctly apply padding to pooling layers when upgrading from V0
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Correctly apply padding to pooling layers when upgrading from V0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pooling layer supports padding for average and max pooling, however the V0 prototext upgrade script doesn't correctly translate pooling layers with padding when upgrading. This fixes that bug.
Currently there is no check that the pooling layer being upgraded uses average or max pooling. I figure it's best to translate the prototxt as is and let downstream operations catch that error (also, in the future padding may be supported for other pooling operations).