add header alphabetization to lint checks #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be run again next time "make lint" is run.
includes are correctly alphabetized.
|
Oh cool, thanks for this Jeff! |
jeffdonahue
added a commit
that referenced
this pull request
Aug 5, 2014
add header alphabetization to lint checks
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
add header alphabetization to lint checks
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
add header alphabetization to lint checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build/include_alphalint rule checks that the headers are alphabetized. It was disabled in the default lint, but since at least @Yangqing has commented on someone's PR to fix header alphabetization (can't find the link right now, but it was what inspired this..), might as well automate those kinds of comments?