-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ammunition-Dialog #31
Open
Dorbedo
wants to merge
15
commits into
BWMod:staging
Choose a base branch
from
Dorbedo:ammo_dialog
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The maximum Magazine Storage is now recognized. - can be overwritten for each vehicle individually
Cool, well yes finish it. I will test it this evening. |
There are no macros used (at least only these, which are specified inside bwa3_common). |
Alright. A little feedback would be nice. |
Works great, but i need some more internal response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Currently ACE_rearm does not support magazines from the weapon config.
This results in the fact, that you are not able to rearm your Leopard with e.g. Canister ammunition.
With this little pull request, the gap will be filled with a small dialog where you can modify the current magazines. You can compare it with the pylon dialog, but much more simple.
This is a first working version. If you could imagine to include this, I'll finish it for this comp patch.