Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ammunition-Dialog #31

Open
wants to merge 15 commits into
base: staging
Choose a base branch
from
Open

Conversation

Dorbedo
Copy link

@Dorbedo Dorbedo commented Dec 7, 2017

When merged this pull request will:

  • Adds an Ammo-Dialog to modify the current magazine loadout
  • requires a near ammunition depot (truck/box/etc.)

Currently ACE_rearm does not support magazines from the weapon config.
This results in the fact, that you are not able to rearm your Leopard with e.g. Canister ammunition.
With this little pull request, the gap will be filled with a small dialog where you can modify the current magazines. You can compare it with the pylon dialog, but much more simple.

image

This is a first working version. If you could imagine to include this, I'll finish it for this comp patch.

- The maximum Magazine Storage is now recognized.
- can be overwritten for each vehicle individually
@ir0n1e
Copy link
Contributor

ir0n1e commented Dec 7, 2017

Cool, well yes finish it. I will test it this evening.
But we will have a problem with the ACE preprocessor. You have to write the plain text
eg.: Quote(ACE_bla) "ACE_bla" and so on.

@Dorbedo
Copy link
Author

Dorbedo commented Dec 7, 2017

There are no macros used (at least only these, which are specified inside bwa3_common).

@Dorbedo
Copy link
Author

Dorbedo commented Dec 9, 2017

Alright. A little feedback would be nice.

@ir0n1e
Copy link
Contributor

ir0n1e commented Dec 10, 2017

Works great, but i need some more internal response

@MarcBook
Copy link
Collaborator

@ir0n1e should I build a RC with this branch for internal testing?
@commy2 Can you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants