-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
level
output for the TextureBlock / switch for disabling level multiplication
#10192
Conversation
4168d25
to
18b94bc
Compare
level
output for the TextureBlocklevel
output for the TextureBlock / switch for disabling level multiplication
LGTM aside the // FIXME block which needs to be removed. @Popov72 will provide a more in depth analysis :-) |
Yeah, I couldn't find the reason for that. Would look into it again later today, but would also appreciate any help with that. Maybe there is something obvious that I've overlooked. |
a27830a
to
3deb5f5
Compare
3deb5f5
to
db47f93
Compare
Done! |
db47f93
to
3e411ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Great job!
One small thing is that 3 functions have been removed from bumpFragmentFunctions.fx
and that could be a breaking change if someone was using them...
However, I don't think this code was supposed to be called by external users and having 3 x perturbNormal + 2 x cotangent_frame
functions reduced to 1 x perturbNormal + 1 x cotangent_frame
sounds good to me, so let's keep it!
It's a good thing there is a 5.0 release coming then ;) I'll fix the nits in a couple of hours when I'm not on mobile! Thanks! |
3e411ac
to
e7dca4d
Compare
Nits are done, thanks for the feedback! |
Follow-up to 4a17889 (PR BabylonJS#10192). "Disable level multiplication" needs to be shown even if no texture is loaded, since otherwise developing a material from NME becomes more difficult.
This PR is a playground for the discussion in https://forum.babylonjs.com/t/nme-make-texture-level-work-for-normal-maps-as-it-does-in-other-materials/19443/14. This code currently does not work (at all!), but might work someday.