Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing loop support for NME #15599

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Introducing loop support for NME #15599

merged 9 commits into from
Sep 19, 2024

Conversation

deltakosh
Copy link
Contributor

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

@deltakosh deltakosh enabled auto-merge (squash) September 19, 2024 16:30
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15599/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 19, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15599/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't lie to you, I didn't understand everything: I trust you that it's working as expected! :)

@deltakosh deltakosh merged commit c7e709f into master Sep 19, 2024
10 of 12 checks passed
@deltakosh deltakosh deleted the nme-loop branch September 19, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants