Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpectorJS broken in Chrome Canary due to new, lower postMessage size limit #69

Closed
kenrussell opened this issue Oct 12, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@kenrussell
Copy link
Contributor

kenrussell commented Oct 12, 2017

Chrome version: 63.0.3236.0 (Official Build) canary (64-bit)
OS: macOS 10.12.6 on Retina MacBook Pro, NVIDIA GPU

To reproduce :

  1. Load https://webglsamples.org/aquarium/aquarium.html
  2. Record a frame from the canvas via Spector.js
  3. The record will fail to display.
  4. Open the console

It contains:

Uncaught Error: Message length exceeded maximum allowed length.
    at PortImpl.postMessage (extensions::messaging:121:13)
    at Port.publicClassPrototype.(anonymous function) [as postMessage] (extensions::utils:138:26)
    at Object.sendMessageImpl (extensions::messaging:399:12)
    at Object. (extensions::runtime:57:15)
    at Object.handleRequest (extensions::binding:64:27)
    at Object. (extensions::binding:374:32)
    at sendMessage (chrome-extension://denbgaamihkadbghdceggmchnflmhpmk/contentScript.js:18:28)
    at HTMLDocument. (chrome-extension://denbgaamihkadbghdceggmchnflmhpmk/contentScript.js:206:9)
@kenrussell
Copy link
Contributor Author

CC'ing @fserb .

@sebavan
Copy link
Member

sebavan commented Oct 12, 2017

Hello @kenrussell

Thank for the feedback. Are you aware of anything I could/should use in Canary to share a huge amount of data with an extension ?

Also What is the current limit ?

I will fix it as soon as we agree on the best strategy for this. I hope I won t have to split the capture to make the extension work.

Thx

@NuclearCookie
Copy link

if you find a different way to send data to extensions, it might help with #63

@NuclearCookie
Copy link

I just stumbled upon this: https://github.com/krakenjs/post-robot Do you think this could fix the issue?

@sebavan
Copy link
Member

sebavan commented Oct 16, 2017

I ll have a look at it, thx. I will wait the answer to this issue before integrating #63 .

@sebavan sebavan self-assigned this Oct 18, 2017
@sebavan sebavan added the bug label Oct 18, 2017
@sebavan sebavan added this to the Version 1.0 milestone Oct 18, 2017
kenrussell added a commit to kenrussell/Spector.js that referenced this issue Oct 20, 2017
split it into chunks in order to work around new message size limits
imposed in Chrome.

Fixes BabylonJS#69.
@kenrussell
Copy link
Contributor Author

Happy to report that I found a small and localized fix for this problem. :)

@deltakosh
Copy link
Contributor

Thanks! Much appreciated ;)

@kenrussell
Copy link
Contributor Author

You're welcome, happy to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants