Merge pull request #54 from Backbase/ci-enhancements

CI enhancements

.github/workflows/ci.yml

@@ -21,6 +21,11 @@ jobs:
         uses: gradle/wrapper-validation-action@v1
       - name: Build
         run: ./gradlew clean build --stacktrace
+      - name: Report Detekt results
+        uses: github/codeql-action/upload-sarif@v1
+        with:
+          sarif_file: ${{ github.workspace }}/build/detekt/sarif
+          checkout_path: ${{ github.workspace }}
       - name: Instrumented tests
         uses: reactivecircus/android-emulator-runner@v2.14.3
         with:
@@ -33,3 +38,20 @@ jobs:
           check_name: Android test report for API ${{ matrix.api-level }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
           report_paths: "**/build/outputs/androidTest-results/connected/flavors/debugAndroidTest/TEST-*.xml"
+
+  scan_for_secrets:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out the repo
+        uses: actions/checkout@v2
+        with:
+          # Allows Gitleaks to scan the commit history of a whole PR:
+          fetch-depth: '0'
+      - name: Fetch Gitleaks rules
+        uses: wei/wget@v1
+        with:
+          args: -O .rules.toml https://raw.githubusercontent.com/fnxpt/gitleaks-action/rules/.rules.toml
+      - name: Gitleaks
+        uses: zricethezav/gitleaks-action@v1.3.0
+        with:
+          config-path: .rules.toml

build.gradle

@@ -26,6 +26,8 @@ buildscript {
         classpath 'org.jetbrains.kotlinx:binary-compatibility-validator:0.3.0'
 
         classpath 'dev.drewhamilton.extracare:extracare-gradle-plugin:0.5.0'
+
+        classpath 'io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.15.0'
     }
 
     repositories {

deferred-resources/src/main/java/com/backbase/deferredresources/DeferredTypeface.kt

@@ -79,7 +79,9 @@ public interface DeferredTypeface {
         override fun resolve(context: Context, fontCallback: ResourcesCompat.FontCallback, handler: Handler?) {
             val value = try {
                 resolve(context)
-            } catch (runtimeException: RuntimeException) {
+            } catch (@Suppress("Detekt.TooGenericExceptionCaught") runtimeException: RuntimeException) {
+                // Generic RuntimeException is thrown by Typeface.createFromAsset. We use that to call
+                //  `fontCallback.onFontRetrievalFailed(FAIL_REASON_FONT_NOT_FOUND)` below
                 null
             }