Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Action #196

Merged
merged 24 commits into from
Sep 30, 2022
Merged

Fix GH Action #196

merged 24 commits into from
Sep 30, 2022

Conversation

arthurpalves
Copy link
Collaborator

@arthurpalves arthurpalves commented Sep 30, 2022

What does this PR do

  • Fixes our GH action to switch variants, so that it automatically installs the right version using homebrew.
  • If using a macos-12 runner, homebrew will install using a packaged bottle, taking seconds.
  • Remove steps to prepare a ci build from a previously committed binary, reliant on a manual step

How can it be tested

  1. Ensure your workflow is running on macos-12 and not macos-latest.

  2. Given the following step, variants switch should succeed, installing the latest version (since 1.1.4 is higher and inexistent as of now):

    - uses: backbase/variants@fix/gh-action
      with:
        version: 1.1.4
        platform: ios
        variant: beta
        verbose: true
  1. Given the following step, variants switch should succeed, installing the latest version (when omitted, 'version' defaults to 'latest'):
    - uses: backbase/variants@fix/gh-action
      with:
        platform: ios
        variant: beta
        verbose: true
  1. Given the following step, variants switch should succeed, installing version 1.1.1:
    - uses: backbase/variants@fix/gh-action
      with:
        version: 1.1.1
        platform: ios
        variant: beta
        verbose: true
  1. Given the following step, variants switch should fail. The version is expected in the format 'major.minor.patch' / 'x.y.z':
    - uses: backbase/variants@fix/gh-action
      with:
        version: 1.1
        platform: ios
        variant: beta
        verbose: true

Task

resolves #189

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@arthurpalves arthurpalves merged commit b9d212c into develop Sep 30, 2022
@arthurpalves arthurpalves deleted the fix/gh-action branch September 30, 2022 13:07
arthurpalves added a commit that referenced this pull request Sep 30, 2022
* Fix the `variants-switch` GH action so that it can install specific versions from homebrew instead of rely on a manually created binary (#196)

* chore: install variants via brew instead of 'make ci'

* ref: attempt to run 'variants-switch' action with brew bottle installation

* docs: adjust documentation about Github Action

* chore: remove steps to manually prepare ci build

* ci: specify ruby-version during setup

* tests: correct FastlaneParametersFactoryTests.testFileWrite_correctOutput

* ci: run 'branch' and 'ci' workflows on macos-12

* ci: temporarily disable codecov reports and simplify 'branch' and 'develop' workflows into 'ci' workflow

* bump: version 1.1.3 (#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Marketplace action not picking up the latest release automatically
3 participants