-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GH Action #196
Merged
Merged
Fix GH Action #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.1.2
… the variants-switch action
arthurpalves
force-pushed
the
fix/gh-action
branch
from
September 30, 2022 11:43
d9f7962
to
98b8474
Compare
bb-gminucci
approved these changes
Sep 30, 2022
GMinucci
approved these changes
Sep 30, 2022
arthurpalves
added a commit
that referenced
this pull request
Sep 30, 2022
* Fix the `variants-switch` GH action so that it can install specific versions from homebrew instead of rely on a manually created binary (#196) * chore: install variants via brew instead of 'make ci' * ref: attempt to run 'variants-switch' action with brew bottle installation * docs: adjust documentation about Github Action * chore: remove steps to manually prepare ci build * ci: specify ruby-version during setup * tests: correct FastlaneParametersFactoryTests.testFileWrite_correctOutput * ci: run 'branch' and 'ci' workflows on macos-12 * ci: temporarily disable codecov reports and simplify 'branch' and 'develop' workflows into 'ci' workflow * bump: version 1.1.3 (#197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
macos-12
runner, homebrew will install using a packaged bottle, taking seconds.How can it be tested
Ensure your workflow is running on
macos-12
and notmacos-latest
.Given the following step, variants switch should succeed, installing the latest version (since 1.1.4 is higher and inexistent as of now):
Task
resolves #189
Checklist:
make validation
locally with success