Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude buffer from application/json parsing #28

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Exclude buffer from application/json parsing #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad900bb
do not consider Buffer instances as application/json
jkyberneees Apr 4, 2019
b67f71e
adding tests for Buffer responses
jkyberneees Apr 4, 2019
c3d9209
bumping version number
jkyberneees Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/response-extensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module.exports.send = (options, req, res) => (data = 200, code = 200, headers =
}
if (options.disableResponseEvent !== true) { res.emit('response', params) }

if (typeof data === 'object') {
if (typeof data === 'object' && data instanceof Buffer === false) {
// transparently setting the 'content-type' header if JSON
res.setHeader('content-type', 'application/json')
params.data = JSON.stringify(params.data)
Expand Down
Loading