Extend send method #90
Conversation
- String - Object - Error - Buffer - Stream - Promise
feat(response): add more types in send method
libs/response-extensions.js
Outdated
| @@ -62,9 +64,11 @@ module.exports.send = (options, req, res) => { | |||
| } | |||
|
|
|||
| if (data) { | |||
| if (data instanceof Buffer) { | |||
| if (typeof data === 'string') { | |||
| contentType = contentType || TYPE_PLAIN | |||
There was a problem hiding this comment.
with this we are losing performance, I put in separate functions because directly towards its objective, reassigning parameters is not a good practice.
There was a problem hiding this comment.
Hi Jesus, we are not loosing performance with this, we are gaining 2-4k more requests per second with this updates. I agree, this is not probable nice looking or good practices, but this is very performant, at least according to my stress tests.
There was a problem hiding this comment.
@jkyberneees We should write those tests too, so we can have better quality code.
libs/response-extensions.js
Outdated
| sendError(res, data, cb) | ||
| return | ||
| } | ||
| const [statusCode, errStr] = parseErr(data) |
There was a problem hiding this comment.
sendError does the whole process, it does not return an array so that a destructuring is performed later, this is not good if we want to improve performance.
There was a problem hiding this comment.
Please see my updates, intermediate functions does not end the request, just update the data object. (with exception of the stream support).
I will update this code to actually remove the usage of destructing.
|
Just added a performance benchmark to monitor % node performance/suites/res-send.js
[
{ name: 'statusCode', mean: '0.0000000013' },
{ name: 'undefined', mean: '0.0000000025' },
{ name: 'null', mean: '0.0000000053' },
{ name: 'string', mean: '0.0000000055' },
{ name: 'stream', mean: '0.0000000270' },
{ name: 'buffer', mean: '0.0000000278' },
{ name: 'string + headers', mean: '0.0000000585' },
{ name: 'json', mean: '0.0000002893' },
{ name: 'error', mean: '0.0000003384' },
{ name: 'json + headers', mean: '0.0000003664' }
]
cc @jesusvilla |
Extend send method to support the following data types:
Out of scope: