Feat/db #66
Open
Feat/db #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad3r
force-pushed
the
master
branch
2 times, most recently
from
4c12d03
to
6244543
Compare
Bad3r
force-pushed
the
master
branch
4 times, most recently
from
9a2e078
to
458ac81
Compare
tiensonqin
force-pushed
the
feat/db
branch
2 times, most recently
from
ec41c85
to
b66a3b8
Compare
1. cache :block/title calculation 2. sort rows if only sorting changed 3. use string/includes? instead of fuzzy search
To bring more power to dsl query `(property db-attribute value)`.
which could have caused subtle bugs. Also cleaned up user-options so future changes don't require making so many changes
accessible to users as they are implementation details that could change
properties and not internal attributes like :block/title and :block/created-at
Our idents should stay in their existing namespaces to leverage clojure's namespaces for future functionality. Also capitalized all built-in queryable property names to be consistent
…e preview page modal
Refactor: dsl query
Throwing errors on unsupported filters for these makes it seem like we support it when we don't. Better to be explicit. Also tweak related tests so that file graph filters only run for file graphs
instead of deleted page-property rules
for db graphs. Also tweaked example graph so blocks and pages have same property values in order to QA property rules like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.