Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Natchez tracing into producer #827

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Integrate Natchez tracing into producer #827

merged 4 commits into from
Jan 2, 2024

Conversation

rossabaker
Copy link
Contributor

This is a simplified version of #826. It traces just the outer buffer and inner ack effect, propagating the Natchez kernel.

  • The ack is a child of the corresponding buffer
  • The ack span will start after the send is complete
  • The ack span will not start until the producer's caller sequences it. This is a metric of how long the producer is waiting for it. If you want metrics for Kafka's health, look at Kafka.

@rossabaker rossabaker requested a review from a team as a code owner January 2, 2024 16:31
zcox
zcox approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@zcox zcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 nice!!

@rossabaker rossabaker mentioned this pull request Jan 2, 2024
Closed
@rossabaker rossabaker merged commit 576ff2c into main Jan 2, 2024
11 checks passed
@rossabaker rossabaker deleted the natchez-alt branch January 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcox zcox zcox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossabaker @zcox