KAYAK-3387 Most Consumer operations are blocking and interruptible #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amohrland
reviewed
Jan 9, 2024
core/src/main/scala/com/banno/kafka/consumer/ConsumerImpl.scala
Outdated
Show resolved
Hide resolved
zcox
changed the title
OddKristensen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAYAK-3387 These consumer operations are synchronous and blocking. The calling thread is blocked until results are returned. There may be some asynchronous I/O down underneath in the Java consumer, but we don't have access to it. These operations should thus be shifted to cats-effect's blocking context/thread pool, so that no threads in the compute pool are blocked.
This PR uses
interruptibleinstead of justblocking. There is evidence thatThread.interruptwill actually interrupt/cancel the underlying operations.Also removed some unneeded trace/debug logging from the consumer.
Reference: CE3 thread model.